You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/14 20:59:30 UTC
[GitHub] [arrow] wesm opened a new pull request #7764: ARROW-9390: [C++][Followup] Add underscores to is* string functions
wesm opened a new pull request #7764:
URL: https://github.com/apache/arrow/pull/7764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #7764: ARROW-9390: [C++][Followup] Add underscores to is* string functions
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #7764:
URL: https://github.com/apache/arrow/pull/7764#discussion_r454644099
##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -944,33 +944,33 @@ void RegisterScalarStringAscii(FunctionRegistry* registry) {
MakeUnaryStringBatchKernel<AsciiUpper>("ascii_upper", registry);
MakeUnaryStringBatchKernel<AsciiLower>("ascii_lower", registry);
- AddUnaryStringPredicate<IsAscii>("string_isascii", registry);
-
- AddUnaryStringPredicate<IsAlphaNumericAscii>("ascii_isalnum", registry);
- AddUnaryStringPredicate<IsAlphaAscii>("ascii_isalpha", registry);
- AddUnaryStringPredicate<IsDecimalAscii>("ascii_isdecimal", registry);
- // no isdigic for ascii, since it is the same as isdecimal
- AddUnaryStringPredicate<IsLowerAscii>("ascii_islower", registry);
- // no isnumeric for ascii, since it is the same as isdecimal
- AddUnaryStringPredicate<IsPrintableAscii>("ascii_isprintable", registry);
- AddUnaryStringPredicate<IsSpaceAscii>("ascii_isspace", registry);
- AddUnaryStringPredicate<IsTitleAscii>("ascii_istitle", registry);
- AddUnaryStringPredicate<IsUpperAscii>("ascii_isupper", registry);
+ AddUnaryStringPredicate<IsAscii>("string_is_ascii", registry);
+
+ AddUnaryStringPredicate<IsAlphaNumericAscii>("ascii_is_alnum", registry);
+ AddUnaryStringPredicate<IsAlphaAscii>("ascii_is_alpha", registry);
+ AddUnaryStringPredicate<IsDecimalAscii>("ascii_is_decimal", registry);
+ // no is_digic for ascii, since it is the same as is_decimal
Review comment:
is_digic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7764: ARROW-9390: [C++][Followup] Add underscores to is* string functions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7764:
URL: https://github.com/apache/arrow/pull/7764#issuecomment-658412404
https://issues.apache.org/jira/browse/ARROW-9390
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7764: ARROW-9390: [C++][Followup] Add underscores to is* string functions
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7764:
URL: https://github.com/apache/arrow/pull/7764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7764: ARROW-9390: [C++][Followup] Add underscores to is* string functions
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7764:
URL: https://github.com/apache/arrow/pull/7764#issuecomment-658410462
cc @nealrichardson
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org