[GitHub] spark pull request #18114: [SPARK-20889][SparkR] Grouped documentation for D...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18114#discussion_r118635475
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -2095,26 +2061,28 @@ setMethod("atan2", signature(y = "Column"),
                 column(jc)
               })
     
    -#' datediff
    +#' @section Details:
    +#' \code{datediff}: Returns the number of days from \code{start} to \code{end}.
     #'
    -#' Returns the number of days from \code{start} to \code{end}.
    -#'
    -#' @param x start Column to use.
    -#' @param y end Column to use.
    --- End diff --
    
    two concerns here:
    - the doc description is now fairly generalized - is supposed to be `datediff(end, start)` but seems like it's not not clear which is end and which is start
    - renaming this could break user calling by name `datediff(df$c, x = "foo")`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org