You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/09/28 00:00:27 UTC
[GitHub] [calcite] danny0405 commented on a change in pull request #1477:
[CALCITE-3377] HSQLDB is case insensitive
danny0405 commented on a change in pull request #1477: [CALCITE-3377] HSQLDB is case insensitive
URL: https://github.com/apache/calcite/pull/1477#discussion_r329284897
##########
File path: core/src/main/java/org/apache/calcite/sql/dialect/HsqldbSqlDialect.java
##########
@@ -35,7 +35,8 @@
public class HsqldbSqlDialect extends SqlDialect {
public static final SqlDialect DEFAULT =
new HsqldbSqlDialect(EMPTY_CONTEXT
- .withDatabaseProduct(DatabaseProduct.HSQLDB));
+ .withDatabaseProduct(DatabaseProduct.HSQLDB)
+ .withCaseSensitive(false));
Review comment:
You can add test cases in `RelToSqlConverterTest`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services