You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by he...@apache.org on 2019/04/23 17:04:59 UTC
[geode] branch develop updated: GEODE-6693: run concurrency tests
for longer (#3488)
This is an automated email from the ASF dual-hosted git repository.
heybales pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/develop by this push:
new 88b3c51 GEODE-6693: run concurrency tests for longer (#3488)
88b3c51 is described below
commit 88b3c512c77389c58027d851e2a10066e9fb49ad
Author: Helena Bales <hb...@pivotal.io>
AuthorDate: Tue Apr 23 10:04:46 2019 -0700
GEODE-6693: run concurrency tests for longer (#3488)
Run the concurrency test runner for longer by default to increase the
chance of catching issues, and move runner's tests to the integration
level since they are non-deterministic.
Signed-off-by: Jacob Barrett <jb...@pivotal.io>
---
geode-concurrency-test/build.gradle | 4 ++--
.../org/apache/geode/test/concurrency/ConcurrentTestRunnerTest.java | 2 +-
.../main/java/org/apache/geode/test/concurrency/loop/LoopRunner.java | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/geode-concurrency-test/build.gradle b/geode-concurrency-test/build.gradle
index 9138536..d29d5e4 100644
--- a/geode-concurrency-test/build.gradle
+++ b/geode-concurrency-test/build.gradle
@@ -23,10 +23,10 @@ dependencies {
compile(platform(project(':boms:geode-all-bom')))
compile('junit:junit')
compile('org.apache.logging.log4j:log4j-api')
- testCompile('org.assertj:assertj-core')
+ integrationTestCompile('org.assertj:assertj-core')
}
-test {
+integrationTest {
// Some tests have inner tests that should be ignored
exclude "**/*\$*.class"
}
diff --git a/geode-concurrency-test/src/test/java/org/apache/geode/test/concurrency/ConcurrentTestRunnerTest.java b/geode-concurrency-test/src/integrationTest/java/org/apache/geode/test/concurrency/ConcurrentTestRunnerTest.java
similarity index 97%
rename from geode-concurrency-test/src/test/java/org/apache/geode/test/concurrency/ConcurrentTestRunnerTest.java
rename to geode-concurrency-test/src/integrationTest/java/org/apache/geode/test/concurrency/ConcurrentTestRunnerTest.java
index 76e8d01..8840cc5 100644
--- a/geode-concurrency-test/src/test/java/org/apache/geode/test/concurrency/ConcurrentTestRunnerTest.java
+++ b/geode-concurrency-test/src/integrationTest/java/org/apache/geode/test/concurrency/ConcurrentTestRunnerTest.java
@@ -30,7 +30,7 @@ public class ConcurrentTestRunnerTest {
public void confirmThatInParallelRunsConcurrently() {
// We only need FailingTest to fail once for the following
// assertion to pass. ConcurrentTestRunner runs FailingTest
- // 1000 times by default. It will stop running it once it
+ // 2000 times by default. It will stop running it once it
// sees it fail, which is what we want to see because it
// confirms that running inParallel actually runs concurrently.
assertThat(JUnitCore.runClasses(CheckForConcurrency.class).wasSuccessful()).isFalse();
diff --git a/geode-concurrency-test/src/main/java/org/apache/geode/test/concurrency/loop/LoopRunner.java b/geode-concurrency-test/src/main/java/org/apache/geode/test/concurrency/loop/LoopRunner.java
index 0cc0297..68f4fe8 100644
--- a/geode-concurrency-test/src/main/java/org/apache/geode/test/concurrency/loop/LoopRunner.java
+++ b/geode-concurrency-test/src/main/java/org/apache/geode/test/concurrency/loop/LoopRunner.java
@@ -35,7 +35,7 @@ import org.apache.geode.test.concurrency.Runner;
* Simple runner that just runs the test in a loop
*/
public class LoopRunner implements Runner {
- private static final int DEFAULT_COUNT = 1000;
+ private static final int DEFAULT_COUNT = 2000;
@Override
public List<Throwable> runTestMethod(Method child) {