[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5483: GEODE-8462: Make geode server startup fail if geode redis server has a port conflict

[GitBox <gi...@apache.org>]

sabbeyPivotal commented on a change in pull request #5483:
URL: https://github.com/apache/geode/pull/5483#discussion_r480347641



##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java
##########
@@ -99,7 +99,7 @@ public NettyRedisServer(Supplier<DistributionConfig> configSupplier,
       throw new IllegalArgumentException("Redis port cannot be less than 0");
     }
     this.bindAddress = getBindAddress(requestedAddress);
-    selectorGroup = createEventLoopGroup("Selector", false, 1);
+    selectorGroup = createEventLoopGroup("Selector", true, 1);

Review comment:
       Good call, Darrel! Just updated it.  We decided to leave the selectorGroup as a daemon thread.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org