You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/12/25 14:03:18 UTC
[I] remove minExpectedVersion check [incubator-pekko-http]
pjfanning opened a new issue, #380:
URL: https://github.com/apache/incubator-pekko-http/issues/380
See https://github.com/apache/incubator-pekko-http/pull/328
@mdedetrich has suggested that we should be testing with pekko 1.0.2 or latest pekko 1.0.x snapshot (in Slack - link is private).
This check is currently what ties up to pekko 1.0.0.
Alternatively, we need to change the build so we can set the min expected value to 1.0.0 but test with a different version of pekko. I still think the min check is unnecessary. 1.0.0 is our first release so there are no releases that we need to ban. We can add this check back when we need to ban pekko releases (if ever).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] remove minExpectedVersion check [incubator-pekko-http]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #380:
URL: https://github.com/apache/incubator-pekko-http/issues/380#issuecomment-1869038858
I think we can adjust that check than remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] remove minExpectedVersion check [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning closed issue #380: remove minExpectedVersion check
URL: https://github.com/apache/incubator-pekko-http/issues/380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] remove minExpectedVersion check [incubator-pekko-http]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #380:
URL: https://github.com/apache/incubator-pekko-http/issues/380#issuecomment-1869127109
So I am not sure what the "check" part of `minExpectedVersion` check is meant to be, but at least starting off with Pekko (i.e. when we forked Akka), pekko-http should be compatible with **all** versions of Pekko 1.0.x, after all this is what semver means and why both pekko and pekko-http follow semver strictly.
This may be an artifact from older versions of Akka where some functionality was added to Akka that Akka-Http relied on and hence Akka-Http required a minimum version of Akka in order to function.
Until thats the case, I am all for removing this `minExpectedVersion` check and ideally (as discussed on slack) pekko-http (and the other modules) should be building against the latest of Pekko that is semver compatible (which in this case will be Pekko 1.1.x) with nightly checks that link with older minor versions of Pekko (i.e. 1.0.x)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] remove minExpectedVersion check [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #380:
URL: https://github.com/apache/incubator-pekko-http/issues/380#issuecomment-1880061437
#383 and #382 merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] remove minExpectedVersion check [incubator-pekko-http]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #380:
URL: https://github.com/apache/incubator-pekko-http/issues/380#issuecomment-1869165535
@pjfanning On a related note I made a PR against sbt-pekko-build so that we at least are using the latest version of Pekko 1.0.x. In the meantime we can work on removing the check as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] remove minExpectedVersion check [incubator-pekko-http]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #380:
URL: https://github.com/apache/incubator-pekko-http/issues/380#issuecomment-1869006536
We can do a time based release bom, eg 2023-03-release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org