You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@htrace.apache.org by "Nisala Mendis (JIRA)" <ji...@apache.org> on 2016/07/05 18:58:11 UTC

[jira] [Commented] (HTRACE-363) Add tests for newScope with parent id

    [ https://issues.apache.org/jira/browse/HTRACE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363018#comment-15363018 ] 

Nisala Mendis commented on HTRACE-363:
--------------------------------------

Hi Colin,

I have updated the PR as per your review comments.

Regards
Nisala

> Add tests for newScope with parent id
> -------------------------------------
>
>                 Key: HTRACE-363
>                 URL: https://issues.apache.org/jira/browse/HTRACE-363
>             Project: HTrace
>          Issue Type: Test
>          Components: core
>            Reporter: Mike Drob
>            Assignee: Nisala Mendis
>
> We should add some tests to verify that when there is a currently active scope and `newScope` is called with a valid parent id that both are included in the child span. The current code does this correctly, I think, but we should have tests to prevent accidental regressions in the future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)