[GitHub] [hive] ayushtkn commented on a diff in pull request #4024: HIVE-27029: hive query fails with Filesystem closed error, Rework done for HIVE-26352

["ayushtkn (via GitHub)" <gi...@apache.org>]

ayushtkn commented on code in PR #4024:
URL: https://github.com/apache/hive/pull/4024#discussion_r1100201589


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/YarnQueueHelper.java:
##########
@@ -94,19 +94,15 @@ public YarnQueueHelper(HiveConf conf) {
   }
 
   public void checkQueueAccess(
-      String queueName, String userName) throws IOException, InterruptedException {
+      String queueName, String userName) throws IOException {
     UserGroupInformation ugi = UserGroupInformation.getCurrentUser();
     try {
       ugi.doAs((PrivilegedExceptionAction<Void>) () -> {
         checkQueueAccessInternal(queueName, userName);
         return null;
       });
-    } finally {
-      try {
-        FileSystem.closeAllForUGI(ugi);
-      } catch (IOException exception) {
-        LOG.error("Could not clean up file-system handles for UGI: " + ugi, exception);
-      }

Review Comment:
   Who closes the FileSystem now? If there is a FileSystem created per UGI and we don't clean it up, can that lead to OOM issues?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org