You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "Zouxxyy (via GitHub)" <gi...@apache.org> on 2024/05/30 16:27:35 UTC
[PR] [test] Fix flaky test testLookupDynamicPartition [paimon]
Zouxxyy opened a new pull request, #3447:
URL: https://github.com/apache/paimon/pull/3447
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
Fix flaky test testLookupDynamicPartition

### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Fix flaky test testLookupDynamicPartition [paimon]
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on code in PR #3447:
URL: https://github.com/apache/paimon/pull/3447#discussion_r1621720096
##########
paimon-core/src/test/java/org/apache/paimon/utils/TraceableFileIO.java:
##########
@@ -250,15 +251,13 @@ public String toString() {
}
public static List<SeekableInputStream> openInputStreams(Predicate<Path> filter) {
- return OPEN_INPUT_STREAMS.stream()
- .filter(s -> filter.test(s.file))
- .collect(Collectors.toList());
+ return new ArrayList<>(OPEN_INPUT_STREAMS)
Review Comment:
copy out to avoid ConcurrentModificationException, see https://github.com/apache/paimon/actions/runs/9305326341/job/25611978740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Fix flaky test testLookupDynamicPartition [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #3447:
URL: https://github.com/apache/paimon/pull/3447#discussion_r1621707993
##########
paimon-core/src/test/java/org/apache/paimon/utils/TraceableFileIO.java:
##########
@@ -250,15 +251,13 @@ public String toString() {
}
public static List<SeekableInputStream> openInputStreams(Predicate<Path> filter) {
- return OPEN_INPUT_STREAMS.stream()
- .filter(s -> filter.test(s.file))
- .collect(Collectors.toList());
+ return new ArrayList<>(OPEN_INPUT_STREAMS)
Review Comment:
It looks like it's also traversed once, is there any difference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Fix flaky test testLookupDynamicPartition [paimon]
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on code in PR #3447:
URL: https://github.com/apache/paimon/pull/3447#discussion_r1621720096
##########
paimon-core/src/test/java/org/apache/paimon/utils/TraceableFileIO.java:
##########
@@ -250,15 +251,13 @@ public String toString() {
}
public static List<SeekableInputStream> openInputStreams(Predicate<Path> filter) {
- return OPEN_INPUT_STREAMS.stream()
- .filter(s -> filter.test(s.file))
- .collect(Collectors.toList());
+ return new ArrayList<>(OPEN_INPUT_STREAMS)
Review Comment:
copy out to avoid ConcurrentModificationException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Fix flaky test testLookupDynamicPartition [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #3447:
URL: https://github.com/apache/paimon/pull/3447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org