You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/03/04 02:09:49 UTC
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #5439: [Bug] Fix some problem with downloading and building thirdparty
yangzhg commented on a change in pull request #5439:
URL: https://github.com/apache/incubator-doris/pull/5439#discussion_r586979773
##########
File path: thirdparty/build-thirdparty.sh
##########
@@ -472,6 +472,7 @@ build_brpc() {
LDFLAGS="-L${TP_LIB_DIR} -static-libstdc++ -static-libgcc" \
${CMAKE_CMD} -G "${GENERATOR}" -v -DBUILD_SHARED_LIBS=0 -DCMAKE_INSTALL_PREFIX=$TP_INSTALL_DIR \
-DBRPC_WITH_GLOG=ON -DWITH_GLOG=ON -DCMAKE_INCLUDE_PATH="$TP_INSTALL_DIR/include" \
+ -DCMAKE_LIBRARY_PATH="$TP_INSTALL_DIR/lib64" \
Review comment:
now we use a soft link lib and lib64 are same dir， so there is no need to specify DCMAKE_LIBRARY_PATH, you can clean your `installed` dir and recompile again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org