[jira] [Resolved] (IMPALA-6023) impalad failed to start in test_dcheck_writes_minidump

["Lars Volker (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Volker resolved IMPALA-6023.
---------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.11.0

IMPALA-6023: Fix broken breakpad test

We have a test to make sure that hitting a DCHECK will write a minidump.
We used to pass "-beeswax_port=1" to the server to trigger a DCHECK. A
while ago, this DCHECK seems to have been removed, but we still called
abort() if the ImpalaServer failed to start. This masked the slightly
altered behavior and the test still succeeded.

However, the fix for IMPALA-4786 changed the behavior to call exit(1)
instead of abort() if the ImpalaServer failed to start.

To fix the test, we change it to pass an unresolvable hostname to
impalad, which will result in a call to abort().

This change also splits the breakpad tests into core and exhaustive sets
to make sure that tests which depend on other parts of Impala are
included in every core run.

Change-Id: Ifb5af3e72963280a6677a99aa6a0e5785443bb0c
Reviewed-on: http://gerrit.cloudera.org:8080/8240
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins

> impalad failed to start in test_dcheck_writes_minidump
> ------------------------------------------------------
>
>                 Key: IMPALA-6023
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6023
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 2.11.0
>            Reporter: Michael Brown
>            Assignee: Lars Volker
>            Priority: Blocker
>              Labels: broken-build
>             Fix For: Impala 2.11.0
>
>
> [~lv] can you take a look?
> {noformat}
> self = <test_breakpad.TestBreakpad object at 0x5c83290>
>     @SkipIfBuildType.not_dev_build
>     @pytest.mark.execute_serially
>     def test_dcheck_writes_minidump(self):
>       """Check that hitting a DCHECK macro writes a minidump."""
>       assert self.count_all_minidumps() == 0
>       failed_to_start = False
>       try:
>         self.start_cluster_with_args(minidump_path=self.tmp_dir,
>             beeswax_port=1)
>       except CalledProcessError:
>         failed_to_start = True
>       assert failed_to_start
> >     assert self.count_minidumps('impalad') > 0
> E     assert 0 > 0
> E      +  where 0 = <bound method TestBreakpad.count_minidumps of <test_breakpad.TestBreakpad object at 0x5c83290>>('impalad')
> E      +    where <bound method TestBreakpad.count_minidumps of <test_breakpad.TestBreakpad object at 0x5c83290>> = <test_breakpad.TestBreakpad object at 0x5c83290>.count_minidumps
> custom_cluster/test_breakpad.py:321: AssertionError
> ----------------------------- Captured stdout call -----------------------------
> Starting State Store logging to /data/jenkins/workspace/impala-umbrella-build-and-test/repos/Impala/logs/custom_cluster_tests/statestored.INFO
> Starting Catalog Service logging to /data/jenkins/workspace/impala-umbrella-build-and-test/repos/Impala/logs/custom_cluster_tests/catalogd.INFO
> Starting Impala Daemon logging to /data/jenkins/workspace/impala-umbrella-build-and-test/repos/Impala/logs/custom_cluster_tests/impalad.INFO
> Starting Impala Daemon logging to /data/jenkins/workspace/impala-umbrella-build-and-test/repos/Impala/logs/custom_cluster_tests/impalad_node1.INFO
> Starting Impala Daemon logging to /data/jenkins/workspace/impala-umbrella-build-and-test/repos/Impala/logs/custom_cluster_tests/impalad_node2.INFO
> Error starting cluster: num_known_live_backends did not reach expected value in time
> ----------------------------- Captured stderr call -----------------------------
> MainThread: Found 3 impalad/1 statestored/1 catalogd process(es)
> MainThread: Getting num_known_live_backends from impala-boost-static-burst-slave-0055.vpc.cloudera.com:25000
> MainThread: Debug webpage not yet available.
> MainThread: Debug webpage not yet available.
> ...
> MainThread: Debug webpage did not become available in expected time.
> MainThread: Waiting for num_known_live_backends=3. Current value: None
> MainThread: Found 0 impalad/1 statestored/1 catalogd process(es)
> {noformat}
> This was the only test to fail this way:
> {noformat}
> 16:36:32 custom_cluster/test_alloc_fail.py .x
> 16:44:17 custom_cluster/test_breakpad.py .........F
> 16:44:44 custom_cluster/test_client_ssl.py .sss
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)