You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2013/10/23 08:33:18 UTC
Review Request 14869: Added changes related to bug 4920 and few code clean up
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14869/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
1. Currently, there was one issue found in requests library.
2. Added change to strip the command string passed to marvin request command
3. Removed few unwanted code.
4. Made the testclient uniform to pass both mgt and dbsrv details.
Diffs
-----
tools/marvin/marvin/cloudstackConnection.py df88fa2
tools/marvin/marvin/cloudstackTestClient.py 5dcd8bf
tools/marvin/marvin/codegenerator.py 96729f6
tools/marvin/marvin/configGenerator.py 45c3d69
tools/marvin/marvin/deployDataCenter.py 6b5f64b
Diff: https://reviews.apache.org/r/14869/diff/
Testing
-------
Tested changes on simulator, it created entities post the run so it seems tests were working fine.
Thanks,
Santhosh Edukulla
Re: Review Request 14869: Added changes related to bug 4920 and few code
clean up
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14869/#review27368
-----------------------------------------------------------
Ship it!
d4072c6 - master
- Prasanna Santhanam
On Oct. 23, 2013, 8:19 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14869/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2013, 8:19 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Currently, there was one issue found in requests library.
> 2. Added change to strip the command string passed to marvin request command
> 3. Removed few unwanted code.
> 4. Made the testclient uniform to pass both mgt and dbsrv details.
> 5. Fixed one issue in request call
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py df88fa2
> tools/marvin/marvin/cloudstackTestClient.py 5dcd8bf
> tools/marvin/marvin/codegenerator.py 96729f6
> tools/marvin/marvin/configGenerator.py 45c3d69
> tools/marvin/marvin/deployDataCenter.py 6b5f64b
>
> Diff: https://reviews.apache.org/r/14869/diff/
>
>
> Testing
> -------
>
> Tested changes on simulator, it created entities post the run so it seems tests were working fine.
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 14869: Added changes related to bug 4920 and few code
clean up
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14869/#review28524
-----------------------------------------------------------
4.2: 87983e09e21c51dbef6b2a8a0252b039e32915ad
- Girish Shilamkar
On Oct. 23, 2013, 8:19 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14869/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2013, 8:19 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Currently, there was one issue found in requests library.
> 2. Added change to strip the command string passed to marvin request command
> 3. Removed few unwanted code.
> 4. Made the testclient uniform to pass both mgt and dbsrv details.
> 5. Fixed one issue in request call
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py df88fa2
> tools/marvin/marvin/cloudstackTestClient.py 5dcd8bf
> tools/marvin/marvin/codegenerator.py 96729f6
> tools/marvin/marvin/configGenerator.py 45c3d69
> tools/marvin/marvin/deployDataCenter.py 6b5f64b
>
> Diff: https://reviews.apache.org/r/14869/diff/
>
>
> Testing
> -------
>
> Tested changes on simulator, it created entities post the run so it seems tests were working fine.
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 14869: Added changes related to bug 4920 and few code
clean up
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14869/
-----------------------------------------------------------
(Updated Oct. 23, 2013, 8:19 a.m.)
Review request for cloudstack and Prasanna Santhanam.
Repository: cloudstack-git
Description (updated)
-------
1. Currently, there was one issue found in requests library.
2. Added change to strip the command string passed to marvin request command
3. Removed few unwanted code.
4. Made the testclient uniform to pass both mgt and dbsrv details.
5. Fixed one issue in request call
Diffs
-----
tools/marvin/marvin/cloudstackConnection.py df88fa2
tools/marvin/marvin/cloudstackTestClient.py 5dcd8bf
tools/marvin/marvin/codegenerator.py 96729f6
tools/marvin/marvin/configGenerator.py 45c3d69
tools/marvin/marvin/deployDataCenter.py 6b5f64b
Diff: https://reviews.apache.org/r/14869/diff/
Testing
-------
Tested changes on simulator, it created entities post the run so it seems tests were working fine.
Thanks,
Santhosh Edukulla
Re: Review Request 14869: Added changes related to bug 4920 and few code
clean up
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On Oct. 23, 2013, 7:25 a.m., Prasanna Santhanam wrote:
> > tools/marvin/marvin/cloudstackConnection.py, line 169
> > <https://reviews.apache.org/r/14869/diff/1/?file=369602#file369602line169>
> >
> > can we please use # for inline comments in code and """ quoted doc-string comments under methods, classes and modules?
Sometimes, adding #comments for multiline comments decreases readability
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14869/#review27366
-----------------------------------------------------------
On Oct. 23, 2013, 6:33 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14869/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2013, 6:33 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Currently, there was one issue found in requests library.
> 2. Added change to strip the command string passed to marvin request command
> 3. Removed few unwanted code.
> 4. Made the testclient uniform to pass both mgt and dbsrv details.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py df88fa2
> tools/marvin/marvin/cloudstackTestClient.py 5dcd8bf
> tools/marvin/marvin/codegenerator.py 96729f6
> tools/marvin/marvin/configGenerator.py 45c3d69
> tools/marvin/marvin/deployDataCenter.py 6b5f64b
>
> Diff: https://reviews.apache.org/r/14869/diff/
>
>
> Testing
> -------
>
> Tested changes on simulator, it created entities post the run so it seems tests were working fine.
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 14869: Added changes related to bug 4920 and few code
clean up
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14869/#review27366
-----------------------------------------------------------
tools/marvin/marvin/cloudstackConnection.py
<https://reviews.apache.org/r/14869/#comment53225>
can we please use # for inline comments in code and """ quoted doc-string comments under methods, classes and modules?
tools/marvin/marvin/cloudstackConnection.py
<https://reviews.apache.org/r/14869/#comment53226>
I changed the comment to be less verbose. The comment seems superfluous to the flow of the code.
- Prasanna Santhanam
On Oct. 23, 2013, 6:33 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14869/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2013, 6:33 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Currently, there was one issue found in requests library.
> 2. Added change to strip the command string passed to marvin request command
> 3. Removed few unwanted code.
> 4. Made the testclient uniform to pass both mgt and dbsrv details.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/cloudstackConnection.py df88fa2
> tools/marvin/marvin/cloudstackTestClient.py 5dcd8bf
> tools/marvin/marvin/codegenerator.py 96729f6
> tools/marvin/marvin/configGenerator.py 45c3d69
> tools/marvin/marvin/deployDataCenter.py 6b5f64b
>
> Diff: https://reviews.apache.org/r/14869/diff/
>
>
> Testing
> -------
>
> Tested changes on simulator, it created entities post the run so it seems tests were working fine.
>
>
> Thanks,
>
> Santhosh Edukulla
>
>