You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/06/29 10:24:32 UTC
[GitHub] [maven-source-plugin] jorsol opened a new pull request, #7: Add pull request template
jorsol opened a new pull request, #7:
URL: https://github.com/apache/maven-source-plugin/pull/7
Add pull request template and exclude *.md files from rat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-source-plugin] jorsol commented on a diff in pull request #7: Add pull request template
Posted by GitBox <gi...@apache.org>.
jorsol commented on code in PR #7:
URL: https://github.com/apache/maven-source-plugin/pull/7#discussion_r909486703
##########
pom.xml:
##########
@@ -161,6 +161,7 @@ under the License.
<configuration>
<excludes combine.children="append">
<exclude>src/it/reproducible/src/main/resources/**/*.txt</exclude>
+ <exclude>**/*.md</exclude>
Review Comment:
I'm not sure either but haven't really checked why this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-source-plugin] slawekjaranowski commented on a diff in pull request #7: Add pull request template
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #7:
URL: https://github.com/apache/maven-source-plugin/pull/7#discussion_r909479400
##########
pom.xml:
##########
@@ -161,6 +161,7 @@ under the License.
<configuration>
<excludes combine.children="append">
<exclude>src/it/reproducible/src/main/resources/**/*.txt</exclude>
+ <exclude>**/*.md</exclude>
Review Comment:
please only exclude md in .github directory.
We can use md eg in site
by the way is strange ... eg in maven-invoker-plugin we have template but I don't see excludes ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-source-plugin] slawekjaranowski merged pull request #7: Add pull request template
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #7:
URL: https://github.com/apache/maven-source-plugin/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org