You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/10/17 00:35:23 UTC
Review Request 63060: Add an utility function to output the
`csi::Version` protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
The `operator<<` function for `csi::Version` needs to be put in to the
`::csi` namespace so `stringify()` can find it through ADL. Also, we
expose `::csi` in `mesos::csi` in `spec.hpp` instead of `client.hpp`.
Diffs
-----
src/Makefile.am 085ff3b820693c9ef0115a74d72b0d87f158a887
src/csi/client.hpp df674e17260519f983367f7c01f1057a75076238
src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa
src/csi/utils.hpp PRE-CREATION
src/csi/utils.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63060/diff/1/
Testing
-------
make
Thanks,
Chun-Hung Hsiao
Re: Review Request 63060: Added utility functions and structures for
CSI version and capabilities.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/
-----------------------------------------------------------
(Updated Nov. 28, 2017, 12:56 a.m.)
Review request for mesos, Benjamin Mahler and Jie Yu.
Changes
-------
Removed the `csi::` prefix. Since the helper functions are moved into the `::csi` namespace, the prefix is no longer needed.
Repository: mesos
Description
-------
This patch adds some helper structures and functions for CSI protobuf.
The comparison and output operators for `csi::Version` are declared in
the `::csi` namespace so they can find it through ADL. Also, it exposes
`::csi` in `mesos::csi` in `spec.hpp` instead of `client.hpp`.
Diffs (updated)
-----
src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8
src/csi/client.hpp a5571f40eba60a07154a7ef3ebe36c925629ac63
src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa
src/csi/utils.hpp PRE-CREATION
src/csi/utils.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63060/diff/6/
Changes: https://reviews.apache.org/r/63060/diff/5-6/
Testing
-------
make
Thanks,
Chun-Hung Hsiao
Re: Review Request 63060: Added utility functions and structures for
CSI version and capabilities.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/
-----------------------------------------------------------
(Updated Nov. 22, 2017, 5:19 a.m.)
Review request for mesos, Benjamin Mahler and Jie Yu.
Changes
-------
Fixed indentation.
Repository: mesos
Description
-------
This patch adds some helper structures and functions for CSI protobuf.
The comparison and output operators for `csi::Version` are declared in
the `::csi` namespace so they can find it through ADL. Also, it exposes
`::csi` in `mesos::csi` in `spec.hpp` instead of `client.hpp`.
Diffs (updated)
-----
src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8
src/csi/client.hpp a5571f40eba60a07154a7ef3ebe36c925629ac63
src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa
src/csi/utils.hpp PRE-CREATION
src/csi/utils.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63060/diff/5/
Changes: https://reviews.apache.org/r/63060/diff/4-5/
Testing
-------
make
Thanks,
Chun-Hung Hsiao
Re: Review Request 63060: Added utility functions and structures for
CSI version and capabilities.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/
-----------------------------------------------------------
(Updated Nov. 21, 2017, 7:55 p.m.)
Review request for mesos, Benjamin Mahler and Jie Yu.
Changes
-------
Updated based on the new CSI spec.
Repository: mesos
Description
-------
This patch adds some helper structures and functions for CSI protobuf.
The comparison and output operators for `csi::Version` are declared in
the `::csi` namespace so they can find it through ADL. Also, it exposes
`::csi` in `mesos::csi` in `spec.hpp` instead of `client.hpp`.
Diffs (updated)
-----
src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8
src/csi/client.hpp a5571f40eba60a07154a7ef3ebe36c925629ac63
src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa
src/csi/utils.hpp PRE-CREATION
src/csi/utils.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63060/diff/4/
Changes: https://reviews.apache.org/r/63060/diff/3-4/
Testing
-------
make
Thanks,
Chun-Hung Hsiao
Re: Review Request 63060: Added utility functions and structures for
CSI version and capabilities.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/
-----------------------------------------------------------
(Updated Oct. 27, 2017, 11:58 p.m.)
Review request for mesos, Benjamin Mahler and Jie Yu.
Changes
-------
Removed the default clauses for switch statements on proto3 enums.
Summary (updated)
-----------------
Added utility functions and structures for CSI version and capabilities.
Repository: mesos
Description (updated)
-------
This patch adds some helper structures and functions for CSI protobuf.
The comparison and output operators for `csi::Version` are declared in
the `::csi` namespace so they can find it through ADL. Also, it exposes
`::csi` in `mesos::csi` in `spec.hpp` instead of `client.hpp`.
Diffs (updated)
-----
src/Makefile.am b60a54a031260de6f1fb43584ae5083df2dc7e31
src/csi/client.hpp df674e17260519f983367f7c01f1057a75076238
src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa
src/csi/utils.hpp PRE-CREATION
src/csi/utils.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63060/diff/3/
Changes: https://reviews.apache.org/r/63060/diff/2-3/
Testing
-------
make
Thanks,
Chun-Hung Hsiao
Re: Review Request 63060: Added utility functions and structures for
CSI.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
> On Oct. 19, 2017, 5:51 p.m., Jie Yu wrote:
> > src/csi/utils.cpp
> > Lines 25 (patched)
> > <https://reviews.apache.org/r/63060/diff/2/?file=1859642#file1859642line25>
> >
> > Do you need `csi::` prefix?
Yes. `Version` is also defined in stout.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/#review188712
-----------------------------------------------------------
On Oct. 17, 2017, 4:50 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63060/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 4:50 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds some helper structures for CSI capabilities, comparison
> and output operators for `csi::Version` in the `::csi` namespace so
> `stringify()` can find it through ADL. Also, it exposes `::csi` in
> `mesos::csi` in `spec.hpp` instead of `client.hpp`.
>
>
> Diffs
> -----
>
> src/Makefile.am 085ff3b820693c9ef0115a74d72b0d87f158a887
> src/csi/client.hpp df674e17260519f983367f7c01f1057a75076238
> src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa
> src/csi/utils.hpp PRE-CREATION
> src/csi/utils.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63060/diff/2/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 63060: Added utility functions and structures for
CSI.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/#review188712
-----------------------------------------------------------
Fix it, then Ship it!
src/csi/utils.hpp
Lines 77-78 (patched)
<https://reviews.apache.org/r/63060/#comment265726>
The newest spec removed these. You don't need this anymore.
src/csi/utils.hpp
Lines 82-107 (patched)
<https://reviews.apache.org/r/63060/#comment265727>
You don't need this neither. See the new spec.
src/csi/utils.cpp
Lines 25 (patched)
<https://reviews.apache.org/r/63060/#comment265728>
Do you need `csi::` prefix?
src/csi/utils.cpp
Lines 35-36 (patched)
<https://reviews.apache.org/r/63060/#comment265731>
nits:
I would format this this way:
```
return stream << strings::join(
".",
version.major(),
version.minor(),
version.patch());
```
- Jie Yu
On Oct. 17, 2017, 4:50 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63060/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 4:50 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds some helper structures for CSI capabilities, comparison
> and output operators for `csi::Version` in the `::csi` namespace so
> `stringify()` can find it through ADL. Also, it exposes `::csi` in
> `mesos::csi` in `spec.hpp` instead of `client.hpp`.
>
>
> Diffs
> -----
>
> src/Makefile.am 085ff3b820693c9ef0115a74d72b0d87f158a887
> src/csi/client.hpp df674e17260519f983367f7c01f1057a75076238
> src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa
> src/csi/utils.hpp PRE-CREATION
> src/csi/utils.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63060/diff/2/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 63060: Added utility functions and structures for
CSI.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63060/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 4:50 a.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Added utility functions and structures for CSI.
Repository: mesos
Description (updated)
-------
This patch adds some helper structures for CSI capabilities, comparison
and output operators for `csi::Version` in the `::csi` namespace so
`stringify()` can find it through ADL. Also, it exposes `::csi` in
`mesos::csi` in `spec.hpp` instead of `client.hpp`.
Diffs (updated)
-----
src/Makefile.am 085ff3b820693c9ef0115a74d72b0d87f158a887
src/csi/client.hpp df674e17260519f983367f7c01f1057a75076238
src/csi/spec.hpp 60e40e05d81c9bf649459e29479838dd80daa3aa
src/csi/utils.hpp PRE-CREATION
src/csi/utils.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/63060/diff/2/
Changes: https://reviews.apache.org/r/63060/diff/1-2/
Testing
-------
make
Thanks,
Chun-Hung Hsiao