You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/14 08:08:06 UTC

[GitHub] [arrow-datafusion] crepererum commented on a change in pull request #1112: Clean up spawned task on drop for `RepartitionExec`, `SortPreservingMergeExec`, `WindowAggExec`

crepererum commented on a change in pull request #1112:
URL: https://github.com/apache/arrow-datafusion/pull/1112#discussion_r728737688



##########
File path: datafusion/src/physical_plan/repartition.rs
##########
@@ -55,11 +56,14 @@ pub struct RepartitionExec {
     /// Partitioning scheme to use
     partitioning: Partitioning,
     /// Channels for sending batches from input partitions to output partitions.
-    /// Key is the partition number
-    channels: Arc<
-        Mutex<
+    /// Key is the partition number.
+    ///
+    /// Stored alongside is an abort marker that will kill the background job once it's no longer needed.
+    channels_and_abort_helper: Arc<

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org