You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by av...@apache.org on 2017/02/22 00:06:40 UTC

ambari git commit: AMBARI-20104 : Kafka Controller metrics are not being displayed. (avijayan)

Repository: ambari
Updated Branches:
  refs/heads/branch-2.5 e3b21903f -> b3b0b2a0c


AMBARI-20104 : Kafka Controller metrics are not being displayed. (avijayan)


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/b3b0b2a0
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/b3b0b2a0
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/b3b0b2a0

Branch: refs/heads/branch-2.5
Commit: b3b0b2a0c7a5cd83c9502fa8b85ae4f05fe0048b
Parents: e3b2190
Author: Aravindan Vijayan <av...@hortonworks.com>
Authored: Tue Feb 21 16:06:30 2017 -0800
Committer: Aravindan Vijayan <av...@hortonworks.com>
Committed: Tue Feb 21 16:06:30 2017 -0800

----------------------------------------------------------------------
 ambari-metrics/ambari-metrics-kafka-sink/pom.xml            | 7 ++++++-
 .../metrics2/sink/kafka/KafkaTimelineMetricsReporter.java   | 9 ++++++---
 2 files changed, 12 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/b3b0b2a0/ambari-metrics/ambari-metrics-kafka-sink/pom.xml
----------------------------------------------------------------------
diff --git a/ambari-metrics/ambari-metrics-kafka-sink/pom.xml b/ambari-metrics/ambari-metrics-kafka-sink/pom.xml
index 6b75692..dbab1eb 100644
--- a/ambari-metrics/ambari-metrics-kafka-sink/pom.xml
+++ b/ambari-metrics/ambari-metrics-kafka-sink/pom.xml
@@ -144,7 +144,7 @@ limitations under the License.
     <dependency>
       <groupId>org.apache.kafka</groupId>
       <artifactId>kafka_2.10</artifactId>
-      <version>0.8.1.1</version>
+      <version>0.10.1.0</version>
       <exclusions>
         <exclusion>
           <groupId>com.sun.jdmk</groupId>
@@ -169,6 +169,11 @@ limitations under the License.
       </exclusions>
     </dependency>
     <dependency>
+    <groupId>org.apache.kafka</groupId>
+    <artifactId>kafka-clients</artifactId>
+    <version>0.10.1.0</version>
+    </dependency>
+    <dependency>
       <groupId>com.yammer.metrics</groupId>
       <artifactId>metrics-core</artifactId>
       <version>2.2.0</version>

http://git-wip-us.apache.org/repos/asf/ambari/blob/b3b0b2a0/ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
----------------------------------------------------------------------
diff --git a/ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java b/ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
index b9ca9f5..9d492cb 100644
--- a/ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
+++ b/ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
@@ -378,9 +378,12 @@ public class KafkaTimelineMetricsReporter extends AbstractTimelineMetricsSink
       final long currentTimeMillis = System.currentTimeMillis();
       final String sanitizedName = sanitizeName(name);
 
-      cacheSanitizedTimelineMetric(currentTimeMillis, sanitizedName, "", Double.parseDouble(String.valueOf(gauge.value())));
-
-      populateMetricsList(context, MetricType.GAUGE, sanitizedName);
+      try {
+        cacheSanitizedTimelineMetric(currentTimeMillis, sanitizedName, "", Double.parseDouble(String.valueOf(gauge.value())));
+        populateMetricsList(context, MetricType.GAUGE, sanitizedName);
+      } catch (NumberFormatException ex) {
+        LOG.debug(ex.getMessage());
+      }
     }
 
     private String[] cacheKafkaMetered(long currentTimeMillis, String sanitizedName, Metered meter) {