You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by meeramn <gi...@git.apache.org> on 2016/02/19 20:00:57 UTC
[GitHub] trafficserver pull request: TS-4065: Change metrics to counters in...
GitHub user meeramn opened a pull request:
https://github.com/apache/trafficserver/pull/488
TS-4065: Change metrics to counters in RecordsConfig
I have fixed some metrics which have counter semantics by changing them from RECD_INT to RECD_COUNTER. Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meeramn/trafficserver TS-4065
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/488.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #488
----
commit 6738153340be24408e37fc34ac6caf28cd031735
Author: Meera Mosale Nataraja <me...@gmail.com>
Date: 2016-02-19T18:54:29Z
Change metrics to counters in RecordsConfig
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4065: Change metrics to counters in...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/488#issuecomment-187824115
@zwoop will shepard.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4065: Change metrics to counters in...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/488#issuecomment-191056670
The latest patch looks good to me, +1.
Meera: In addition, can you make another PR to fix the documentation for the metrics you found that are marked wrongly in the documentations?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4065: Change metrics to counters in...
Posted by meeramn <gi...@git.apache.org>.
Github user meeramn commented on the pull request:
https://github.com/apache/trafficserver/pull/488#issuecomment-191987949
zwoop: This PR addressed those documentation changes already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4065: Change metrics to counters in...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/488#issuecomment-191992703
Ah good, I must have missed it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4065: Change metrics to counters in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/488
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---