[GitHub] [hadoop] Hexiaoqiao commented on a change in pull request #3247: HDFS-16146. All three replicas are lost due to not adding a new DataN…

[GitBox <gi...@apache.org>]

Hexiaoqiao commented on a change in pull request #3247:
URL: https://github.com/apache/hadoop/pull/3247#discussion_r680669607



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeFaultInjector.java
##########
@@ -68,6 +68,9 @@ public void delaySendingAckToUpstream(final String upstreamAddr)
       throws IOException {
   }
 
+  public void delayAckLastPacket() throws IOException {

Review comment:
       Please add Javadoc for this new injector method.

##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java
##########
@@ -1492,6 +1492,8 @@ public void run() {
           if (lastPacketInBlock) {
             // Finalize the block and close the block file
             finalizeBlock(startTime);
+            /* for test only, no-op in production system */

Review comment:
       Just suggest to use `//` annotation for single line code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org