[GitHub] [iceberg] kbendick commented on a change in pull request #1972: First version of the Iceberg sink for Apache Beam

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #1972:
URL: https://github.com/apache/iceberg/pull/1972#discussion_r592018073



##########
File path: api/src/main/java/org/apache/iceberg/DataFile.java
##########
@@ -35,7 +36,7 @@
 /**
  * Interface for data files listed in a table manifest.
  */
-public interface DataFile extends ContentFile<DataFile> {
+public interface DataFile extends ContentFile<DataFile>, Serializable {

Review comment:
       If we are implementing Serializable, should we add serial version uid?
   
   In particular, I have users that run into issues with things that get stored in state having changed version uids when they're not explicitly pinned.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org