You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/31 03:15:35 UTC
[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #560: SOLR-15951: Local packages
sonatype-lift[bot] commented on a change in pull request #560:
URL: https://github.com/apache/solr/pull/560#discussion_r795317769
##########
File path: solr/core/src/java/org/apache/solr/pkg/PackageLoader.java
##########
@@ -160,16 +247,22 @@ public void notifyListeners(String pkg) {
/**
* represents a package definition in the packages.json
*/
- public class Package implements Closeable {
+ public class Package implements Closeable, MapWriter {
Review comment:
*JavaLangClash:* org.apache.solr.pkg.PackageLoader.Package clashes with java.lang.Package [(details)](https://errorprone.info)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
##########
File path: solr/core/src/java/org/apache/solr/pkg/PackageLoader.java
##########
@@ -181,14 +274,16 @@ public boolean isDeleted() {
}
- private synchronized void updateVersions(List<PackageAPI.PkgVersion> modified) {
+ private synchronized void updateVersions(List<PackageAPI.PkgVersion> modified, Path localpkgDir) {
for (PackageAPI.PkgVersion v : modified) {
Version version = myVersions.get(v.version);
if (version == null) {
log.info("A new version: {} added for package: {} with artifacts {}", v.version, this.name, v.files);
Version ver = null;
try {
- ver = new Version(this, v);
+ ver = v.local == Boolean.TRUE ?
Review comment:
*ReferenceEquality:* Comparison using reference equality instead of value equality [(details)](https://errorprone.info/bugpattern/ReferenceEquality)
(at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org