You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2016/01/22 19:47:37 UTC
Review Request 42666: Deprecating TaskQuery in killTasks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1583
https://issues.apache.org/jira/browse/AURORA-1583
Repository: aurora
Description
-------
Following the path consistent with restartShards using JobKey + instanceIds.
Diffs
-----
NEWS 37a7a7933b20e112416b01260d97fc2f47c24027
api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
Diff: https://reviews.apache.org/r/42666/diff/
Testing
-------
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Jan. 22, 2016, 9:19 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 441
> > <https://reviews.apache.org/r/42666/diff/2/?file=1218548#file1218548line441>
> >
> > Following up from earlier comment - `active()` scoping is absent here, which can result in log noise as illegal task transitions are attempted.
> >
> > Consider pulling the `implicitKillQuery` call out so that it covers all branches.
Misread your comment, I see what you meant now! Refactored implicitQuery to account for both.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115930
-----------------------------------------------------------
On Jan. 22, 2016, 9:13 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 9:13 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1583
> https://issues.apache.org/jira/browse/AURORA-1583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the path consistent with restartShards using JobKey + instanceIds.
>
>
> Diffs
> -----
>
> NEWS 37a7a7933b20e112416b01260d97fc2f47c24027
> api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
> src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
> src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java 065ad425a0d359c3d73db197b528ab45bf9f6bda
> src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
>
> Diff: https://reviews.apache.org/r/42666/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 22, 2016, 1:19 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 441
> > <https://reviews.apache.org/r/42666/diff/2/?file=1218548#file1218548line441>
> >
> > Following up from earlier comment - `active()` scoping is absent here, which can result in log noise as illegal task transitions are attempted.
> >
> > Consider pulling the `implicitKillQuery` call out so that it covers all branches.
>
> Maxim Khutornenko wrote:
> Misread your comment, I see what you meant now! Refactored implicitQuery to account for both.
Oh you read the comment correctly, i read the code incorrectly :-)
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115930
-----------------------------------------------------------
On Jan. 22, 2016, 1:13 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 1:13 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1583
> https://issues.apache.org/jira/browse/AURORA-1583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the path consistent with restartShards using JobKey + instanceIds.
>
>
> Diffs
> -----
>
> NEWS 37a7a7933b20e112416b01260d97fc2f47c24027
> api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
> src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
> src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java 065ad425a0d359c3d73db197b528ab45bf9f6bda
> src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
>
> Diff: https://reviews.apache.org/r/42666/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115930
-----------------------------------------------------------
Fix it, then Ship it!
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java (line 441)
<https://reviews.apache.org/r/42666/#comment176975>
Following up from earlier comment - `active()` scoping is absent here, which can result in log noise as illegal task transitions are attempted.
Consider pulling the `implicitKillQuery` call out so that it covers all branches.
- Bill Farner
On Jan. 22, 2016, 1:13 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 1:13 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1583
> https://issues.apache.org/jira/browse/AURORA-1583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the path consistent with restartShards using JobKey + instanceIds.
>
>
> Diffs
> -----
>
> NEWS 37a7a7933b20e112416b01260d97fc2f47c24027
> api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
> src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
> src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java 065ad425a0d359c3d73db197b528ab45bf9f6bda
> src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
>
> Diff: https://reviews.apache.org/r/42666/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115946
-----------------------------------------------------------
Ship it!
Master (4b3d7bc) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 22, 2016, 9:43 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 9:43 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1583
> https://issues.apache.org/jira/browse/AURORA-1583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the path consistent with restartShards using JobKey + instanceIds.
>
>
> Diffs
> -----
>
> NEWS c9ff0257a9be75b590c4d4829dca49f575bb00e2
> api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
> src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
> src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java 065ad425a0d359c3d73db197b528ab45bf9f6bda
> src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
>
> Diff: https://reviews.apache.org/r/42666/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Jan. 22, 2016, 9:48 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 439
> > <https://reviews.apache.org/r/42666/diff/4/?file=1218607#file1218607line439>
> >
> > DRY? I actually meant to only do the `implicitKillQuery` 1x at the end.
`query` has to remain final to be used later, so this was the easiest approach without extra assignments.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115940
-----------------------------------------------------------
On Jan. 22, 2016, 9:43 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 9:43 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1583
> https://issues.apache.org/jira/browse/AURORA-1583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the path consistent with restartShards using JobKey + instanceIds.
>
>
> Diffs
> -----
>
> NEWS c9ff0257a9be75b590c4d4829dca49f575bb00e2
> api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
> src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
> src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java 065ad425a0d359c3d73db197b528ab45bf9f6bda
> src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
>
> Diff: https://reviews.apache.org/r/42666/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115940
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java (line 438)
<https://reviews.apache.org/r/42666/#comment176978>
DRY? I actually meant to only do the `implicitKillQuery` 1x at the end.
- Bill Farner
On Jan. 22, 2016, 1:43 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 1:43 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1583
> https://issues.apache.org/jira/browse/AURORA-1583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the path consistent with restartShards using JobKey + instanceIds.
>
>
> Diffs
> -----
>
> NEWS c9ff0257a9be75b590c4d4829dca49f575bb00e2
> api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
> src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
> src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java 065ad425a0d359c3d73db197b528ab45bf9f6bda
> src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
>
> Diff: https://reviews.apache.org/r/42666/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 9:43 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Rebased.
Bugs: AURORA-1583
https://issues.apache.org/jira/browse/AURORA-1583
Repository: aurora
Description
-------
Following the path consistent with restartShards using JobKey + instanceIds.
Diffs (updated)
-----
NEWS c9ff0257a9be75b590c4d4829dca49f575bb00e2
api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java 065ad425a0d359c3d73db197b528ab45bf9f6bda
src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
Diff: https://reviews.apache.org/r/42666/diff/
Testing
-------
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115939
-----------------------------------------------------------
This patch does not apply cleanly against master (2da1700), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 22, 2016, 9:36 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 9:36 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1583
> https://issues.apache.org/jira/browse/AURORA-1583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the path consistent with restartShards using JobKey + instanceIds.
>
>
> Diffs
> -----
>
> NEWS 37a7a7933b20e112416b01260d97fc2f47c24027
> api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
> src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
> src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java 065ad425a0d359c3d73db197b528ab45bf9f6bda
> src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
>
> Diff: https://reviews.apache.org/r/42666/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 9:36 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Setting active for all of job-scoped path.
Bugs: AURORA-1583
https://issues.apache.org/jira/browse/AURORA-1583
Repository: aurora
Description
-------
Following the path consistent with restartShards using JobKey + instanceIds.
Diffs (updated)
-----
NEWS 37a7a7933b20e112416b01260d97fc2f47c24027
api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java 065ad425a0d359c3d73db197b528ab45bf9f6bda
src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
Diff: https://reviews.apache.org/r/42666/diff/
Testing
-------
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 9:13 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Bill's comments and test fixes.
Bugs: AURORA-1583
https://issues.apache.org/jira/browse/AURORA-1583
Repository: aurora
Description
-------
Following the path consistent with restartShards using JobKey + instanceIds.
Diffs (updated)
-----
NEWS 37a7a7933b20e112416b01260d97fc2f47c24027
api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java 065ad425a0d359c3d73db197b528ab45bf9f6bda
src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
Diff: https://reviews.apache.org/r/42666/diff/
Testing
-------
./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115903
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Jan. 22, 2016, 10:47 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 10:47 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1583
> https://issues.apache.org/jira/browse/AURORA-1583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the path consistent with restartShards using JobKey + instanceIds.
>
>
> Diffs
> -----
>
> NEWS 37a7a7933b20e112416b01260d97fc2f47c24027
> api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
> src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
> src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
>
> Diff: https://reviews.apache.org/r/42666/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115905
-----------------------------------------------------------
Master (66a4d5f) is red with this patch.
./build-support/jenkins/build.sh
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
:pmdTest
:test
org.apache.aurora.scheduler.thrift.aop.AnnotatedAuroraAdminTest > testAllAuroraSchedulerManagerIfaceMethodsHaveAuthorizingParam FAILED
java.lang.AssertionError at AnnotatedAuroraAdminTest.java:48
org.apache.aurora.scheduler.http.api.security.HttpSecurityIT > testAuroraSchedulerManager FAILED
org.apache.thrift.transport.TTransportException at HttpSecurityIT.java:293
java.lang.AssertionError
I0122 19:14:56.712 [ShutdownHook, SchedulerMain:104] Stopping scheduler services.
931 tests completed, 2 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage is 0.8882782996029824, but must be greater than 0.89
Branch coverage is 0.8200636942675159, but must be greater than 0.835
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 4 mins 39.951 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 22, 2016, 6:47 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 6:47 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1583
> https://issues.apache.org/jira/browse/AURORA-1583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the path consistent with restartShards using JobKey + instanceIds.
>
>
> Diffs
> -----
>
> NEWS 37a7a7933b20e112416b01260d97fc2f47c24027
> api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
> src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
> src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
>
> Diff: https://reviews.apache.org/r/42666/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Jan. 22, 2016, 7:44 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 444
> > <https://reviews.apache.org/r/42666/diff/1/?file=1212356#file1212356line444>
> >
> > Nearly forgot - in this branch, you should log and return a deprecation warning. Cmd-f for 'deprecated' in this file and you will spot an example.
Done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115910
-----------------------------------------------------------
On Jan. 22, 2016, 6:47 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 6:47 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1583
> https://issues.apache.org/jira/browse/AURORA-1583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the path consistent with restartShards using JobKey + instanceIds.
>
>
> Diffs
> -----
>
> NEWS 37a7a7933b20e112416b01260d97fc2f47c24027
> api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
> src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
> src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
>
> Diff: https://reviews.apache.org/r/42666/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115910
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java (line 444)
<https://reviews.apache.org/r/42666/#comment176962>
Nearly forgot - in this branch, you should log and return a deprecation warning. Cmd-f for 'deprecated' in this file and you will spot an example.
- Bill Farner
On Jan. 22, 2016, 10:47 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 10:47 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1583
> https://issues.apache.org/jira/browse/AURORA-1583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the path consistent with restartShards using JobKey + instanceIds.
>
>
> Diffs
> -----
>
> NEWS 37a7a7933b20e112416b01260d97fc2f47c24027
> api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
> src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
> src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
>
> Diff: https://reviews.apache.org/r/42666/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Jan. 22, 2016, 7:42 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java, line 132
> > <https://reviews.apache.org/r/42666/diff/1/?file=1212360#file1212360line132>
> >
> > s/consider removing/Remove/, + link ticket. When we were first building this code, the wildcard was a real pain. Removing it will be welcome!
Done.
> On Jan. 22, 2016, 7:42 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 438
> > <https://reviews.apache.org/r/42666/diff/1/?file=1212356#file1212356line438>
> >
> > s/.active()//, that's already done by `implicitKillQuery()`.
implicitKillQuery is not not called in this code path.
> On Jan. 22, 2016, 7:42 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 429
> > <https://reviews.apache.org/r/42666/diff/1/?file=1212356#file1212356line429>
> >
> > As you've done in `AnnotatedAuroraAdmin`, all 4 of these params should be marked `@Nullable`.
Done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115908
-----------------------------------------------------------
On Jan. 22, 2016, 6:47 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 6:47 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1583
> https://issues.apache.org/jira/browse/AURORA-1583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the path consistent with restartShards using JobKey + instanceIds.
>
>
> Diffs
> -----
>
> NEWS 37a7a7933b20e112416b01260d97fc2f47c24027
> api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
> src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
> src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
>
> Diff: https://reviews.apache.org/r/42666/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 42666: Deprecating TaskQuery in killTasks.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115908
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java (line 429)
<https://reviews.apache.org/r/42666/#comment176954>
As you've done in `AnnotatedAuroraAdmin`, all 4 of these params should be marked `@Nullable`.
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java (line 438)
<https://reviews.apache.org/r/42666/#comment176959>
s/.active()//, that's already done by `implicitKillQuery()`.
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java (line 130)
<https://reviews.apache.org/r/42666/#comment176961>
s/consider removing/Remove/, + link ticket. When we were first building this code, the wildcard was a real pain. Removing it will be welcome!
- Bill Farner
On Jan. 22, 2016, 10:47 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 10:47 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1583
> https://issues.apache.org/jira/browse/AURORA-1583
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the path consistent with restartShards using JobKey + instanceIds.
>
>
> Diffs
> -----
>
> NEWS 37a7a7933b20e112416b01260d97fc2f47c24027
> api/src/main/thrift/org/apache/aurora/gen/api.thrift f099620967a7836538f19545fe373faa335529a4
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 69eab90fa053c917a6a2c60b548802ba450fa80c
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java f6669efe9d00ead3f123dda6f6152ae273e1a6c4
> src/main/python/apache/aurora/client/api/__init__.py ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 3e811a4f4d2c82892217ca1f950ac792303fbcf3
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 79e70fde1633e6dfbed2171cceee0197acae2550
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d12b56eb675e5187fb375a27ace3849fdab1dd8d
> src/test/python/apache/aurora/api_util.py 5b2a5383ffa490dcf651c027074ed42bba0ab644
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8
>
> Diff: https://reviews.apache.org/r/42666/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>