You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/27 17:33:39 UTC

[GitHub] [superset] geido opened a new pull request #14878: fix: Empty tab component in Dashboard cannot be deleted

geido opened a new pull request #14878:
URL: https://github.com/apache/superset/pull/14878


   ### SUMMARY
   Adds a min-height to the tabs component so that when empty the user can still reach the trash icon to delete the component from the dashboard
   
   ### BEFORE
   
   https://user-images.githubusercontent.com/60598000/119870962-9dafae00-bf2a-11eb-967e-125cb883d0ff.mp4
   
   ### AFTER
   
   https://user-images.githubusercontent.com/60598000/119871058-bfa93080-bf2a-11eb-8091-d74389979ac8.mp4
   
   ### TESTING INSTRUCTIONS
   1. Open a dashboard
   2. Add a tab component
   3. Delete all the tabs
   4. Make sure you can reach the trash icon far left when hovering the tab component
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: Fixes #14820
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] github-actions[bot] commented on pull request #14878: fix: Empty tab component in Dashboard cannot be deleted

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14878:
URL: https://github.com/apache/superset/pull/14878#issuecomment-849973612


   @pkdotson Ephemeral environment spinning up at http://34.219.157.222:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] codecov[bot] commented on pull request #14878: fix: Empty tab component in Dashboard cannot be deleted

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14878:
URL: https://github.com/apache/superset/pull/14878#issuecomment-849829537


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14878?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14878](https://codecov.io/gh/apache/superset/pull/14878?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6935412) into [master](https://codecov.io/gh/apache/superset/commit/281d637674ff8c75faea99ae5fc84d3ef6576dce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (281d637) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14878/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #14878   +/-   ##
   =======================================
     Coverage   77.57%   77.57%           
   =======================================
     Files         963      963           
     Lines       49290    49291    +1     
     Branches     6205     6205           
   =======================================
   + Hits        38235    38236    +1     
     Misses      10854    10854           
     Partials      201      201           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `72.43% <100.00%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...d/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/superset/pull/14878/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnMuanN4) | `87.50% <100.00%> (+0.13%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14878?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14878?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [281d637...6935412](https://codecov.io/gh/apache/superset/pull/14878?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on pull request #14878: fix: Empty tab component in Dashboard cannot be deleted

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #14878:
URL: https://github.com/apache/superset/pull/14878#issuecomment-856179368


   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] github-actions[bot] commented on pull request #14878: fix: Empty tab component in Dashboard cannot be deleted

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14878:
URL: https://github.com/apache/superset/pull/14878#issuecomment-856438837


   Ephemeral environment shutdown and build artifacts deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] pkdotson commented on pull request #14878: fix: Empty tab component in Dashboard cannot be deleted

Posted by GitBox <gi...@apache.org>.
pkdotson commented on pull request #14878:
URL: https://github.com/apache/superset/pull/14878#issuecomment-849972658


   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on a change in pull request #14878: fix: Empty tab component in Dashboard cannot be deleted

Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #14878:
URL: https://github.com/apache/superset/pull/14878#discussion_r643699554



##########
File path: superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx
##########
@@ -89,6 +89,10 @@ const StyledTabsContainer = styled.div`
   .ant-tabs {
     overflow: visible;
 
+    .ant-tabs-nav-wrap {
+      min-height: ${({ theme }) => theme.gridUnit * 12.5}px;

Review comment:
       Hello @suddjian. Thanks for your feedback. This is to make it exactly 50px which should be the default height of the tabs component. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] suddjian commented on a change in pull request #14878: fix: Empty tab component in Dashboard cannot be deleted

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #14878:
URL: https://github.com/apache/superset/pull/14878#discussion_r643533034



##########
File path: superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx
##########
@@ -89,6 +89,10 @@ const StyledTabsContainer = styled.div`
   .ant-tabs {
     overflow: visible;
 
+    .ant-tabs-nav-wrap {
+      min-height: ${({ theme }) => theme.gridUnit * 12.5}px;

Review comment:
       Nit, non-blocking: Why this `12.5` value here? Could we round it to a whole value or else add a comment noting the reason?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] suddjian commented on a change in pull request #14878: fix: Empty tab component in Dashboard cannot be deleted

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #14878:
URL: https://github.com/apache/superset/pull/14878#discussion_r643533034



##########
File path: superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx
##########
@@ -89,6 +89,10 @@ const StyledTabsContainer = styled.div`
   .ant-tabs {
     overflow: visible;
 
+    .ant-tabs-nav-wrap {
+      min-height: ${({ theme }) => theme.gridUnit * 12.5}px;

Review comment:
       Nit, non-blocking: Why this `12.5` value here? Could we round it to a whole value?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on pull request #14878: fix: Empty tab component in Dashboard cannot be deleted

Posted by GitBox <gi...@apache.org>.
geido commented on pull request #14878:
URL: https://github.com/apache/superset/pull/14878#issuecomment-849813409


   @junlincc @rusackas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] suddjian commented on a change in pull request #14878: fix: Empty tab component in Dashboard cannot be deleted

Posted by GitBox <gi...@apache.org>.
suddjian commented on a change in pull request #14878:
URL: https://github.com/apache/superset/pull/14878#discussion_r646875188



##########
File path: superset-frontend/src/dashboard/components/gridComponents/Tabs.jsx
##########
@@ -89,6 +89,10 @@ const StyledTabsContainer = styled.div`
   .ant-tabs {
     overflow: visible;
 
+    .ant-tabs-nav-wrap {
+      min-height: ${({ theme }) => theme.gridUnit * 12.5}px;

Review comment:
       If this is meant to match the tabs component, it would be nice to have them both reference the same constant value instead of magic numbers that happen to match up.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rusackas merged pull request #14878: fix: Empty tab component in Dashboard cannot be deleted

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #14878:
URL: https://github.com/apache/superset/pull/14878


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] github-actions[bot] commented on pull request #14878: fix: Empty tab component in Dashboard cannot be deleted

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14878:
URL: https://github.com/apache/superset/pull/14878#issuecomment-856187362


   @junlincc Ephemeral environment spinning up at http://54.70.95.188:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org