You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2016/02/09 14:36:44 UTC

Review Request 43359: Fixed the build with gcc 5.2.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43359/
-----------------------------------------------------------

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
-------

(An unsigned<->signed comparison was failing.)


Diffs
-----

  src/tests/containerizer/isolator_tests.cpp c20f33ebd6b0b1703c513c0d4bfe4f7d3a9201c8 

Diff: https://reviews.apache.org/r/43359/diff/


Testing
-------


Thanks,

Bernd Mathiske


Re: Review Request 43359: Fixed the build with gcc 5.2.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43359/#review118388
-----------------------------------------------------------


Ship it!




Ship It!

- Till Toenshoff


On Feb. 9, 2016, 1:36 p.m., Bernd Mathiske wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43359/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2016, 1:36 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> (An unsigned<->signed comparison was failing.)
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/isolator_tests.cpp c20f33ebd6b0b1703c513c0d4bfe4f7d3a9201c8 
> 
> Diff: https://reviews.apache.org/r/43359/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>


Re: Review Request 43359: Fixed the build with gcc 5.2.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43359/
-----------------------------------------------------------

(Updated Feb. 9, 2016, 5:45 a.m.)


Review request for mesos and Till Toenshoff.


Changes
-------

Added testing info.


Repository: mesos


Description (updated)
-------

An unsigned<->signed comparison was failing.


Diffs
-----

  src/tests/containerizer/isolator_tests.cpp c20f33ebd6b0b1703c513c0d4bfe4f7d3a9201c8 

Diff: https://reviews.apache.org/r/43359/diff/


Testing (updated)
-------

Checked that the build completes "make check" with gcc 5.2.1.


Thanks,

Bernd Mathiske