Re: [PR] Pipe: Fix infinite loop when thread is interrupted in invoking PipeMemoryBlock#close & Avoid new InterruptedException in conditions that can be self-restoring [iotdb]

["VGalaxies (via GitHub)" <gi...@apache.org>]

VGalaxies commented on code in PR #14471:
URL: https://github.com/apache/iotdb/pull/14471#discussion_r1889859022


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/event/response/SubscriptionEventTsFileResponse.java:
##########
@@ -234,7 +234,7 @@ private void waitForResourceEnough4Slicing(final long timeoutMs) throws Interrup
       if (waitTimeSeconds * 1000 > timeoutMs) {
         // should contain 'TimeoutException' in exception message
         // see org.apache.iotdb.rpc.subscription.exception.SubscriptionTimeoutException.KEYWORD
-        throw new InterruptedException(
+        throw new SubscriptionException(

Review Comment:
   Remove all InterruptedException flags from the call stack, like https://github.com/apache/iotdb/blob/master/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/event/response/SubscriptionEventTsFileResponse.java#L115, https://github.com/apache/iotdb/blob/master/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/event/response/SubscriptionEventTsFileResponse.java#L120, https://github.com/apache/iotdb/blob/master/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/event/response/SubscriptionEventTsFileResponse.java#L120



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org