You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/02/13 11:02:15 UTC

[GitHub] zeppelin pull request #2015: [ZEPPELIN-2103] Unnecessary read from Helium re...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/zeppelin/pull/2015

    [ZEPPELIN-2103] Unnecessary read from Helium registry

    ### What is this PR for?
    Every `Helium.getAllPackageInfo()` call read helium package information from all registry configured (both local registry, online registry by default).
    Problem is, `Helium.getAllPackageInfo()` is used inside of many other methods. like `Helium.suggestApp()`, `Helium.enable()`, `Helium.disable()`, `Helium.recreateBundle()`, `Helium.getPackageInfo()`.
    So local/remote registry is unnecessarily accessed more than it should do.
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - Hold the result and reuse it
    * [x] - Unit test
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2103
    
    ### How should this be tested?
    Unittest included
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-2103

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2015.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2015
    
----
commit b58346facb349a8a6e2135f578fb2cfa98486e3d
Author: Lee moon soo <mo...@apache.org>
Date:   2017-02-13T10:59:30Z

    Hold package info and reuse unless refresh flag set to true

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2015: [ZEPPELIN-2103] Unnecessary read to Helium regi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2015


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2015: [ZEPPELIN-2103] Unnecessary read to Helium regi...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo closed the pull request at:

    https://github.com/apache/zeppelin/pull/2015


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2015: [ZEPPELIN-2103] Unnecessary read to Helium registry

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2015
  
    I will review this soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2015: [ZEPPELIN-2103] Unnecessary read to Helium registry

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2015
  
    Looks good to me!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2015: [ZEPPELIN-2103] Unnecessary read to Helium registry

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2015
  
    Thanks @1ambda @felixcheung for review.
    Merge to master if no further comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2015: [ZEPPELIN-2103] Unnecessary read to Helium regi...

Posted by Leemoonsoo <gi...@git.apache.org>.
GitHub user Leemoonsoo reopened a pull request:

    https://github.com/apache/zeppelin/pull/2015

    [ZEPPELIN-2103] Unnecessary read to Helium registry

    ### What is this PR for?
    Every `Helium.getAllPackageInfo()` call read helium package information from all registry configured (both local registry, online registry by default).
    Problem is, `Helium.getAllPackageInfo()` is used inside of many other methods. like `Helium.suggestApp()`, `Helium.enable()`, `Helium.disable()`, `Helium.recreateBundle()`, `Helium.getPackageInfo()`.
    So local/remote registry is unnecessarily accessed more than it should do.
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - Hold the result and reuse it
    * [x] - Unit test
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2103
    
    ### How should this be tested?
    Unittest included
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-2103

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2015.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2015
    
----
commit 57d19f77b295b907c64c420587ce0dedb370f280
Author: Lee moon soo <mo...@apache.org>
Date:   2017-02-13T10:59:30Z

    Hold package info and reuse unless refresh flag set to true

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---