You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/05 05:50:14 UTC

[GitHub] [incubator-kvrocks] ShooterIT commented on a diff in pull request #809: If unix socket is specified, don't listen default TCP if addr:port wasn't set

ShooterIT commented on code in PR #809:
URL: https://github.com/apache/incubator-kvrocks/pull/809#discussion_r962500028


##########
src/config.cc:
##########
@@ -44,6 +44,8 @@ const char *errNotEnableBlobDB = "Must set rocksdb.enable_blob_files to yes firs
 const char *errNotSetLevelCompactionDynamicLevelBytes =
             "Must set rocksdb.level_compaction_dynamic_level_bytes yes first.";
 
+const char *kDefaultBindAddress = "0.0.0.0";

Review Comment:
   i think default bind address should be "127.0.0.1" which is safer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org