[jira] [Commented] (SPARK-7176) Add validation functionality to individual Param

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516544#comment-14516544 ] 

Apache Spark commented on SPARK-7176:
-------------------------------------

User 'jkbradley' has created a pull request for this issue:
https://github.com/apache/spark/pull/5740

> Add validation functionality to individual Param
> ------------------------------------------------
>
>                 Key: SPARK-7176
>                 URL: https://issues.apache.org/jira/browse/SPARK-7176
>             Project: Spark
>          Issue Type: Sub-task
>          Components: ML
>            Reporter: Joseph K. Bradley
>            Assignee: Joseph K. Bradley
>
> This issue was brought up by [https://issues.apache.org/jira/browse/SPARK-7147]: There are multiple locations in which a parameter can be specified (in setters and in calling fit/transform), and we should check the parameter value in each one.  It would be nice to avoid duplicating the checking code.
> Proposed change:
> * Add field to class Param: {{val isValid: T => Boolean}}, with default value of always returning true
> * Add helper methods in new ParamCheck object for constructing common validation checks (especially to help Java users)
> * Ensure that this validation is always done, most likely by always settings parameters by constructing a ParamPair + validating inside the ParamPair constructor



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org