[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1260: HDDS-3423. Enabling TestContainerReplicationEndToEnd and addressing f…

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #1260:
URL: https://github.com/apache/hadoop-ozone/pull/1260#discussion_r461568738



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestContainerReplicationEndToEnd.java
##########
@@ -167,9 +166,13 @@ public void testContainerReplication() throws Exception {
             .getPipeline(pipelineID);
     key.close();
 
-    if (cluster.getStorageContainerManager().getContainerManager()
-        .getContainer(new ContainerID(containerID)).getState() !=
-        HddsProtos.LifeCycleState.CLOSING) {
+    HddsProtos.LifeCycleState containerState =
+        cluster.getStorageContainerManager().getContainerManager()
+            .getContainer(new ContainerID(containerID)).getState();
+    LoggerFactory.getLogger(TestContainerReplicationEndToEnd.class).info(
+        "Current Container State is " + containerState);

Review comment:
       Please use placeholder in log message instead of `+` to avoid new code warning (sonar).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org