You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "sishen (JIRA)" <ji...@apache.org> on 2008/10/18 13:42:44 UTC

[jira] Created: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

REST Interface:   enable to get numbers of rows from scanner interface
----------------------------------------------------------------------

                 Key: HBASE-936
                 URL: https://issues.apache.org/jira/browse/HBASE-936
             Project: Hadoop HBase
          Issue Type: Improvement
          Components: rest
    Affects Versions: 0.18.0
            Reporter: sishen
             Fix For: 0.18.0


The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack reassigned HBASE-936:
---------------------------

    Assignee: sishen

> REST Interface:   enable to get numbers of rows from scanner interface
> ----------------------------------------------------------------------
>
>                 Key: HBASE-936
>                 URL: https://issues.apache.org/jira/browse/HBASE-936
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.18.0
>            Reporter: sishen
>            Assignee: sishen
>             Fix For: 0.19.0
>
>         Attachments: 936.trunk.rest_scanner.patch, 936.trunk.rest_scanner_v2.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

Posted by "sishen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

sishen updated HBASE-936:
-------------------------

    Attachment:     (was: 936.trunk.rest_scanner.patch)

> REST Interface:   enable to get numbers of rows from scanner interface
> ----------------------------------------------------------------------
>
>                 Key: HBASE-936
>                 URL: https://issues.apache.org/jira/browse/HBASE-936
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.18.0
>            Reporter: sishen
>             Fix For: 0.18.0
>
>         Attachments: 936.trunk.rest_scanner.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

Posted by "sishen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

sishen updated HBASE-936:
-------------------------

    Attachment: 936.trunk.rest_scanner.patch

> REST Interface:   enable to get numbers of rows from scanner interface
> ----------------------------------------------------------------------
>
>                 Key: HBASE-936
>                 URL: https://issues.apache.org/jira/browse/HBASE-936
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.18.0
>            Reporter: sishen
>             Fix For: 0.18.0
>
>         Attachments: 936.trunk.rest_scanner.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

Posted by "sishen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643133#action_12643133 ] 

sishen commented on HBASE-936:
------------------------------

Stack: if accomodate J-D's suggestion, i think we must apply the patch of HBASE-959 at first.  

> REST Interface:   enable to get numbers of rows from scanner interface
> ----------------------------------------------------------------------
>
>                 Key: HBASE-936
>                 URL: https://issues.apache.org/jira/browse/HBASE-936
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.18.0
>            Reporter: sishen
>             Fix For: 0.19.0
>
>         Attachments: 936.trunk.rest_scanner.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643125#action_12643125 ] 

stack commented on HBASE-936:
-----------------------------

Sishen: Are you going to update this patch to accomodate J-D's suggestion?

> REST Interface:   enable to get numbers of rows from scanner interface
> ----------------------------------------------------------------------
>
>                 Key: HBASE-936
>                 URL: https://issues.apache.org/jira/browse/HBASE-936
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.18.0
>            Reporter: sishen
>             Fix For: 0.19.0
>
>         Attachments: 936.trunk.rest_scanner.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

Posted by "sishen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

sishen updated HBASE-936:
-------------------------

    Attachment: 936.trunk.rest_scanner.patch

fix NullPointerException

> REST Interface:   enable to get numbers of rows from scanner interface
> ----------------------------------------------------------------------
>
>                 Key: HBASE-936
>                 URL: https://issues.apache.org/jira/browse/HBASE-936
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.18.0
>            Reporter: sishen
>             Fix For: 0.18.0
>
>         Attachments: 936.trunk.rest_scanner.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

Posted by "sishen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640850#action_12640850 ] 

sishen commented on HBASE-936:
------------------------------

Hi, J-D.

Thanks for the mention.  I haven't put the eyes on that before.  Will change using the new apis.

> REST Interface:   enable to get numbers of rows from scanner interface
> ----------------------------------------------------------------------
>
>                 Key: HBASE-936
>                 URL: https://issues.apache.org/jira/browse/HBASE-936
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.18.0
>            Reporter: sishen
>             Fix For: 0.19.0
>
>         Attachments: 936.trunk.rest_scanner.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

Posted by "sishen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

sishen updated HBASE-936:
-------------------------

    Attachment: 936.trunk.rest_scanner_v2.patch

Accomodate J-D's suggestion.  And also add the new next(int nbRows) method to the Scanner interface.

> REST Interface:   enable to get numbers of rows from scanner interface
> ----------------------------------------------------------------------
>
>                 Key: HBASE-936
>                 URL: https://issues.apache.org/jira/browse/HBASE-936
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.18.0
>            Reporter: sishen
>             Fix For: 0.19.0
>
>         Attachments: 936.trunk.rest_scanner.patch, 936.trunk.rest_scanner_v2.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-936:
------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

If all internal, no need to do deprecation.

Applied.  Thanks for the patch Sishen.

> REST Interface:   enable to get numbers of rows from scanner interface
> ----------------------------------------------------------------------
>
>                 Key: HBASE-936
>                 URL: https://issues.apache.org/jira/browse/HBASE-936
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.18.0
>            Reporter: sishen
>             Fix For: 0.19.0
>
>         Attachments: 936.trunk.rest_scanner.patch, 936.trunk.rest_scanner_v2.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643297#action_12643297 ] 

stack commented on HBASE-936:
-----------------------------

Sishen: It looks like you are just removing the next() and hasNext() from the REST Scanner rather than first deprecating it?  As is, if folks have written code that expects next(), they'll get a surprise.   Do they have to be removed?  If so, would suggest you instead deprecate them and then remove them in a later release -- 0.20.0. 

> REST Interface:   enable to get numbers of rows from scanner interface
> ----------------------------------------------------------------------
>
>                 Key: HBASE-936
>                 URL: https://issues.apache.org/jira/browse/HBASE-936
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.18.0
>            Reporter: sishen
>             Fix For: 0.19.0
>
>         Attachments: 936.trunk.rest_scanner.patch, 936.trunk.rest_scanner_v2.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

Posted by "sishen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643300#action_12643300 ] 

sishen commented on HBASE-936:
------------------------------

Yes.  I reimplemented the ScannerRecord. But it's only used in ScannerHandler internally and i have changed all the logic.  is this ok?  Do I still need to deprecate it at first?

> REST Interface:   enable to get numbers of rows from scanner interface
> ----------------------------------------------------------------------
>
>                 Key: HBASE-936
>                 URL: https://issues.apache.org/jira/browse/HBASE-936
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.18.0
>            Reporter: sishen
>             Fix For: 0.19.0
>
>         Attachments: 936.trunk.rest_scanner.patch, 936.trunk.rest_scanner_v2.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans updated HBASE-936:
-------------------------------------

    Fix Version/s:     (was: 0.18.0)
                   0.19.0

Moved this into 0.19.0 since we don't release new features in 0.18.

Also, did you take a look at HBASE-887? Can you confirm that there are no bad interactions between your patch and the current state of trunk? Thanks!

> REST Interface:   enable to get numbers of rows from scanner interface
> ----------------------------------------------------------------------
>
>                 Key: HBASE-936
>                 URL: https://issues.apache.org/jira/browse/HBASE-936
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.18.0
>            Reporter: sishen
>             Fix For: 0.19.0
>
>         Attachments: 936.trunk.rest_scanner.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-936) REST Interface: enable to get numbers of rows from scanner interface

Posted by "sishen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

sishen updated HBASE-936:
-------------------------

    Status: Patch Available  (was: Open)

The default numbers of rows is 1. So it will not affect the current apis.  User can add limit parma to the search string, such as /[tables]/scanner/[scanner_id]?limit=10.

The result will be <rows><row>..</row><row>..</row>..</rows> if limit > 1, else <row>..</row>



> REST Interface:   enable to get numbers of rows from scanner interface
> ----------------------------------------------------------------------
>
>                 Key: HBASE-936
>                 URL: https://issues.apache.org/jira/browse/HBASE-936
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: rest
>    Affects Versions: 0.18.0
>            Reporter: sishen
>             Fix For: 0.18.0
>
>         Attachments: 936.trunk.rest_scanner.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The scanner request will return one row for each request defaultly. But due to reduce the network bandwidth also the usability of the api, it should allow return multiple rows at once.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.