You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "michaeljmarshall (via GitHub)" <gi...@apache.org> on 2023/06/02 18:59:43 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request, #20482: [fix][fn] Support customizing TLS config for function download command
michaeljmarshall opened a new pull request, #20482:
URL: https://github.com/apache/pulsar/pull/20482
### Motivation
We support configuring custom TLS trusted certs when running functions, but not when downloading them. This PR fixes that by mapping the configuration in the same way we do with functions:
https://github.com/apache/pulsar/blob/f04252b84a8b594ea371645e367c491aa8e2dd80/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeUtils.java#L425-L434
### Modifications
* Configure using TLS, allowing insecure TLS, hostname verification, and the custom trusted cert path
### Verifying this change
I added a new test.
### Documentation
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #20482: [fix][fn] Support customizing TLS config for function download command
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #20482:
URL: https://github.com/apache/pulsar/pull/20482#issuecomment-1610271420
As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #20482: [fix][fn] Support customizing TLS config for function download command
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #20482:
URL: https://github.com/apache/pulsar/pull/20482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20482: [fix][fn] Support customizing TLS config for function download command
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #20482:
URL: https://github.com/apache/pulsar/pull/20482#issuecomment-1574443010
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #20482: [fix][fn] Support customizing TLS config for function download command
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #20482:
URL: https://github.com/apache/pulsar/pull/20482#issuecomment-1574608781
> Sorry. I notice that it respects existing passed values instead of new options. Then it's reasonable to pick, while still may not for 2.9 (and 2.10?) which is EOL.
I haven't seen us declare 2.9 EOL, and the PIP 47 that would indicate that it is EOL hasn't really been followed. I'm going to cherry pick it, and then if it gets released, it's there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20482: [fix][fn] Support customizing TLS config for function download command
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20482:
URL: https://github.com/apache/pulsar/pull/20482#issuecomment-1574348057
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20482?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20482](https://app.codecov.io/gh/apache/pulsar/pull/20482?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (69c28fe) into [master](https://app.codecov.io/gh/apache/pulsar/commit/e220a5d04ae16d1b8dfd7e35cdddf43f3a43fe86?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e220a5d) will **increase** coverage by `0.34%`.
> The diff coverage is `100.00%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20482?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20482 +/- ##
============================================
+ Coverage 72.59% 72.94% +0.34%
- Complexity 31719 31907 +188
============================================
Files 1867 1867
Lines 138523 138529 +6
Branches 15204 15205 +1
============================================
+ Hits 100555 101044 +489
+ Misses 29955 29469 -486
- Partials 8013 8016 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.20% <0.00%> (+0.06%)` | :arrow_up: |
| systests | `25.11% <0.00%> (+0.12%)` | :arrow_up: |
| unittests | `72.21% <100.00%> (+0.36%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/20482?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...unctions/runtime/kubernetes/KubernetesRuntime.java](https://app.codecov.io/gh/apache/pulsar/pull/20482?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWZ1bmN0aW9ucy9ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvZnVuY3Rpb25zL3J1bnRpbWUva3ViZXJuZXRlcy9LdWJlcm5ldGVzUnVudGltZS5qYXZh) | `38.96% <100.00%> (+0.61%)` | :arrow_up: |
... and [118 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20482/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #20482: [fix][fn] Support customizing TLS config for function download command
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #20482:
URL: https://github.com/apache/pulsar/pull/20482#issuecomment-1574624251
Looks like it doesn't apply cleanly. I'll have to investigate cherry picking it a bit more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org