You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/06/15 23:00:40 UTC

[GitHub] [helix] micahstubbs opened a new pull request, #2159: Delete Cluster UI

micahstubbs opened a new pull request, #2159:
URL: https://github.com/apache/helix/pull/2159

   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the PR description:
   
   #2158 
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   ![Screen Shot 2022-06-15 at 3 55 22 PM](https://user-images.githubusercontent.com/2119400/173955820-35f5a9e0-99a2-4c05-bbcf-dd61399a2d8d.png)
   
   ### Tests
   
   - [x] The following tests are written for this issue:
   
   `cluster-detail.component.spec.ts`
   
   -[x] The following is the result of the "mvn test" command on the appropriate module:
   
   No Maven Tests for helix-front.
   
   ### Commits
   
   - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
   
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   
   No Java Changes. See #2157 for helix-front code formatting tooling.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] micahstubbs commented on pull request #2159: Delete Cluster UI [helix-front]

Posted by GitBox <gi...@apache.org>.
micahstubbs commented on PR #2159:
URL: https://github.com/apache/helix/pull/2159#issuecomment-1157070882

   This PR is ready to be merged, approved by @somecodemonkey      
   Final commit message:
   ## Delete Cluster UI (#2158)
   Enable deleting a cluster from the cluster detail page in the UI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] somecodemonkey commented on pull request #2159: Delete Cluster UI [helix-front]

Posted by GitBox <gi...@apache.org>.
somecodemonkey commented on PR #2159:
URL: https://github.com/apache/helix/pull/2159#issuecomment-1157062917

   👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] NealSun96 merged pull request #2159: Delete Cluster UI [helix-front]

Posted by GitBox <gi...@apache.org>.
NealSun96 merged PR #2159:
URL: https://github.com/apache/helix/pull/2159


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org