You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by "DomGarguilo (via GitHub)" <gi...@apache.org> on 2023/03/24 14:49:30 UTC

[GitHub] [accumulo-examples] DomGarguilo commented on pull request #121: Add overloaded Common.createTableWithNamespace() with NTC

DomGarguilo commented on PR #121:
URL: https://github.com/apache/accumulo-examples/pull/121#issuecomment-1482928594

   > Looks good. The only thing I'd change is rename `ntc` to `newTableConfig`. The examples are supposed to be instructive, and that change may make it more clear what the variable is when it's used. However, it's fine as is, if that change would make the readability worse with line breaks/formatting.
   
   Good idea. Updated in 5d915bb and I think readability has improved with this suggestion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org