You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/07 11:11:23 UTC

[GitHub] [flink] xintongsong opened a new pull request #12022: [FLINK-15154] Change Flink binding addresses in local execution mode

xintongsong opened a new pull request #12022:
URL: https://github.com/apache/flink/pull/12022


   ## What is the purpose of the change
   
   This PR fixes the problem that Flink's bind address in local execution mode is not configurable.
   
   Currently, Flink listens to 3 ports in local execution mode, for the following purposes.
   1. Rest endpoint
   2. Blob server
   3. Metrics query RPC service
   
   While binding address for 1 can be configure via `rest.bind-address`, those for 2 & 3 cannot be configured.
   
   ## Brief change log
   
   - Make blob server respect the configuration option 'jobmanager.bind-host' for its binding address.
   - Make metrics query RPC service use akka local actor system in local execution mode, to avoid unnecessary port binding.
   
   ## Verifying this change
   
   Manually verified by executing jobs in local mode and checking all the network ports the process binds to.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xintongsong edited a comment on pull request #12022: [FLINK-15154][runtime] Change Flink binding addresses in local execution mode

Posted by GitBox <gi...@apache.org>.
xintongsong edited a comment on pull request #12022:
URL: https://github.com/apache/flink/pull/12022#issuecomment-625192571


   cc @tillrohrmann 
   Would you have time to help take a look at this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12022: [FLINK-15154][runtime] Change Flink binding addresses in local execution mode

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12022:
URL: https://github.com/apache/flink/pull/12022#issuecomment-625199438


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "42fa4c35c53bf1c0e76ce1220867874199f976ca",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "42fa4c35c53bf1c0e76ce1220867874199f976ca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 42fa4c35c53bf1c0e76ce1220867874199f976ca UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12022: [FLINK-15154] Change Flink binding addresses in local execution mode

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12022:
URL: https://github.com/apache/flink/pull/12022#issuecomment-625191414


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 42fa4c35c53bf1c0e76ce1220867874199f976ca (Thu May 07 11:15:45 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12022: [FLINK-15154][runtime] Change Flink binding addresses in local execution mode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12022:
URL: https://github.com/apache/flink/pull/12022#issuecomment-625199438


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "42fa4c35c53bf1c0e76ce1220867874199f976ca",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=745",
       "triggerID" : "42fa4c35c53bf1c0e76ce1220867874199f976ca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 42fa4c35c53bf1c0e76ce1220867874199f976ca Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=745) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xintongsong commented on pull request #12022: [FLINK-15154][runtime] Change Flink binding addresses in local execution mode

Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #12022:
URL: https://github.com/apache/flink/pull/12022#issuecomment-625192571


   cc @tillrohrmann 
   Would you have time to help take a look this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12022: [FLINK-15154][runtime] Change Flink binding addresses in local execution mode

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12022:
URL: https://github.com/apache/flink/pull/12022#issuecomment-625199438


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "42fa4c35c53bf1c0e76ce1220867874199f976ca",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=745",
       "triggerID" : "42fa4c35c53bf1c0e76ce1220867874199f976ca",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 42fa4c35c53bf1c0e76ce1220867874199f976ca Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=745) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org