You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/30 15:31:54 UTC

[GitHub] [incubator-nuttx] SimonFilgis opened a new pull request #4923: Cerrypick ksz8061 regs

SimonFilgis opened a new pull request #4923:
URL: https://github.com/apache/incubator-nuttx/pull/4923


   ## Summary
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4923: Cerrypick ksz8061 regs

Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #4923:
URL: https://github.com/apache/incubator-nuttx/pull/4923#discussion_r759401738



##########
File path: include/nuttx/net/mii.h
##########
@@ -128,7 +128,6 @@
 #define MII_KSZ8061_OP_MODE            0x16   /* Operation Mode */
 #define MII_KSZ8061_OP_MODE_STRAP_STAT 0x17   /* Operation Mode Strap Status */
 #define MII_KSZ8061_EXP_CTRL           0x18   /* Expanded Control */
-//#define MII_KSZ8061_RESERVED         0x19   /* - 1Ah Reserved */

Review comment:
       Hi @SimonFilgis when a register/region is reserved we normally just keep the comments, like this:
   ```
                                                      /* 0x19 - 0x1A Reserved */
   ```
   But not problem removing it like you did.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4923: Cerrypick ksz8061 regs

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4923:
URL: https://github.com/apache/incubator-nuttx/pull/4923


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org