You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/26 07:25:50 UTC
[GitHub] [spark] Eugene-Mark opened a new pull request, #36993: [SPARK-39604][SQL][TESTS] Add UT for DerbyDialect getCatalystType method
Eugene-Mark opened a new pull request, #36993:
URL: https://github.com/apache/spark/pull/36993
### What changes were proposed in this pull request?
Add complemented UT for DerbyDialect
### Why are the changes needed?
Add UT for existed key function.
If conversion from original data source to Spark data type is needed, the `getCatalystType` method will be added to specific ${data-source}Dialects class, need to add UT for each of them. Currently, all *Dialect class has UT to cover the method instead of DerbyDialect.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit Test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a diff in pull request #36993: [SPARK-39604][SQL][TESTS] Add UT for DerbyDialect getCatalystType method
Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #36993:
URL: https://github.com/apache/spark/pull/36993#discussion_r907932049
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala:
##########
@@ -924,6 +924,13 @@ class JDBCSuite extends QueryTest
assert(derbyDialect.getJDBCType(BooleanType).map(_.databaseTypeDefinition).get == "BOOLEAN")
}
+ test("SPARK-39604: DerbyDialect catalyst type mapping") {
+ val derbyDialect = JdbcDialects.get("jdbc:derby:db")
+ val metadata = new MetadataBuilder().putString("name", "test_column")
+ assert(derbyDialect.getCatalystType(java.sql.Types.REAL, "real",
+ 0, metadata) == Some(FloatType))
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a diff in pull request #36993: [SPARK-39604][SQL][TESTS] Add UT for DerbyDialect getCatalystType method
Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #36993:
URL: https://github.com/apache/spark/pull/36993#discussion_r906921157
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala:
##########
@@ -924,6 +924,13 @@ class JDBCSuite extends QueryTest
assert(derbyDialect.getJDBCType(BooleanType).map(_.databaseTypeDefinition).get == "BOOLEAN")
}
+ test("SPARK-39604: DerbyDialect catalyst type mapping") {
+ val derbyDialect = JdbcDialects.get("jdbc:derby:db")
+ val metadata = new MetadataBuilder().putString("name", "test_column")
+ assert(derbyDialect.getCatalystType(java.sql.Types.REAL, "real",
+ 0, metadata) == Some(FloatType))
Review Comment:
Could we put this test into `DerbyDialect jdbc type mapping` like other dialects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eugene-Mark commented on pull request #36993: [SPARK-39604][SQL][TESTS] Add UT for DerbyDialect getCatalystType method
Posted by GitBox <gi...@apache.org>.
Eugene-Mark commented on PR #36993:
URL: https://github.com/apache/spark/pull/36993#issuecomment-1166564419
@srowen It's appreciated if it can be reviewed in your convenience, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #36993: [SPARK-39604][SQL][TESTS] Add UT for DerbyDialect getCatalystType method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36993:
URL: https://github.com/apache/spark/pull/36993#issuecomment-1167292134
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #36993: [SPARK-39604][SQL][TESTS] Add UT for DerbyDialect getCatalystType method
Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #36993:
URL: https://github.com/apache/spark/pull/36993#issuecomment-1168101305
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eugene-Mark commented on a diff in pull request #36993: [SPARK-39604][SQL][TESTS] Add UT for DerbyDialect getCatalystType method
Posted by GitBox <gi...@apache.org>.
Eugene-Mark commented on code in PR #36993:
URL: https://github.com/apache/spark/pull/36993#discussion_r907475109
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala:
##########
@@ -924,6 +924,13 @@ class JDBCSuite extends QueryTest
assert(derbyDialect.getJDBCType(BooleanType).map(_.databaseTypeDefinition).get == "BOOLEAN")
}
+ test("SPARK-39604: DerbyDialect catalyst type mapping") {
+ val derbyDialect = JdbcDialects.get("jdbc:derby:db")
+ val metadata = new MetadataBuilder().putString("name", "test_column")
+ assert(derbyDialect.getCatalystType(java.sql.Types.REAL, "real",
+ 0, metadata) == Some(FloatType))
Review Comment:
Good point about the consistency! However, currently we have MysqlDialects, TerdataDialects and DerbyDialects that have separated UT for `getJDBCType` and `getCatalystType`. It seems not bad to separate them since the two methods serves as different goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Eugene-Mark commented on a diff in pull request #36993: [SPARK-39604][SQL][TESTS] Add UT for DerbyDialect getCatalystType method
Posted by GitBox <gi...@apache.org>.
Eugene-Mark commented on code in PR #36993:
URL: https://github.com/apache/spark/pull/36993#discussion_r907478695
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala:
##########
@@ -924,6 +924,13 @@ class JDBCSuite extends QueryTest
assert(derbyDialect.getJDBCType(BooleanType).map(_.databaseTypeDefinition).get == "BOOLEAN")
}
+ test("SPARK-39604: DerbyDialect catalyst type mapping") {
+ val derbyDialect = JdbcDialects.get("jdbc:derby:db")
+ val metadata = new MetadataBuilder().putString("name", "test_column")
+ assert(derbyDialect.getCatalystType(java.sql.Types.REAL, "real",
+ 0, metadata) == Some(FloatType))
Review Comment:
I'm Okay to put them all together or separate the others just like how MysqlDialacts did. But I'm neutral to which one is better, may I kindly know your preference about it? @wangyum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #36993: [SPARK-39604][SQL][TESTS] Add UT for DerbyDialect getCatalystType method
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #36993: [SPARK-39604][SQL][TESTS] Add UT for DerbyDialect getCatalystType method
URL: https://github.com/apache/spark/pull/36993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org