You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2019/03/29 16:19:55 UTC

[Impala-ASF-CR] [Docker] Enable running docker-based tests on Ubuntu 14 

Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12892


Change subject: [Docker] Enable running docker-based tests on Ubuntu 14
......................................................................

[Docker] Enable running docker-based tests on Ubuntu 14

Tweak the Docker-based test driver to allow it to run on Ubuntu 14.04.

1. Change the memory statistics gathering code to go directly to
   /proc/meminfo instead of parsing the output of 'free', which
   varies considerably across OS distributions.
   This makes test-with-docker.py depend on the MemAvailable field
   in /proc/meminfo, which should be present on kernels v3.14 and above.
   This also foregoes forking 'free' once per second.

2. Relax the check for a valid timezone specifier.
   On Ubuntu 14.04 /etc/localtime is a copy of a timezone file instead
   of being a symlink to a timezone file.
   Add an alternative check that accepts this option for timezone
   synchronization between the host and the Docker containers.

3. Centos 6 did not like the leading dash in the 'ps' command argument
   list. Change this to a universally accepted form by dropping
   the leading dash.
   Tested by running 'ps axho' manually on all OSs supported for
   Docker-based tests.

Change-Id: I6d326611772facc193d8e509a827515f10207808
---
M docker/entrypoint.sh
M docker/monitor.py
M docker/test-with-docker.py
3 files changed, 49 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/12892/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................


Patch Set 10:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19307/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 10
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 May 2025 14:17:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................


Patch Set 9: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 9
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 18:47:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12892/5/docker/monitor.py
File docker/monitor.py:

http://gerrit.cloudera.org:8080/#/c/12892/5/docker/monitor.py@80
PS5, Line 80: l
flake8: E741 ambiguous variable name 'l'


http://gerrit.cloudera.org:8080/#/c/12892/5/docker/monitor.py@82
PS5, Line 82: l
flake8: E741 ambiguous variable name 'l'



-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 5
Gerrit-Owner: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Sun, 31 Jul 2022 20:50:21 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Laszlo Gaal (Cloudera) (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12892

to look at the new patch set (#5).

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................

Make Docker-based tests available on more hosting OS platforms

Tweak the test driver and the monitoring code to be compatible with
more OS versions:

1. Change the code collecting memory statistics to go directly to
   /proc/meminfo instead of parsing the output of 'free', which
   requires different arguments on different OS distributions.
   This makes test-with-docker.py depend on the MemAvailable field
   in /proc/meminfo, which should be present on kernels v3.14 and above.
   This also foregoes forking 'free' once per second.

2. Relax the check for a valid timezone specifier.
   On Ubuntu 14.04 /etc/localtime is a copy of a timezone file instead
   of being a symlink to a timezone file.
   Add an alternative check that accepts this option for timezone
   synchronization between the host and the Docker containers.

3. Centos 6 did not like the leading dash in the 'ps' command argument
   list. Change this to a universally accepted form by dropping
   the leading dash.
   Tested by running 'ps axho' manually on all OSs supported for
   Docker-based tests.

Change-Id: I6d326611772facc193d8e509a827515f10207808
---
M docker/entrypoint.sh
M docker/monitor.py
M docker/test-with-docker.py
3 files changed, 51 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/12892/5
-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 5
Gerrit-Owner: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>

[Impala-ASF-CR] [Docker] Enable running docker-based tests on Ubuntu 14

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: [Docker] Enable running docker-based tests on Ubuntu 14
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2590/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 16:57:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................


Patch Set 3:

(3 comments)

Fixed flake8 style findings.

http://gerrit.cloudera.org:8080/#/c/12892/1/docker/monitor.py
File docker/monitor.py:

http://gerrit.cloudera.org:8080/#/c/12892/1/docker/monitor.py@75
PS1, Line 75: 
> flake8: E501 line too long (93 > 90 characters)
Done


http://gerrit.cloudera.org:8080/#/c/12892/1/docker/monitor.py@81
PS1, Line 81: 
> flake8: E201 whitespace after '('
Done


http://gerrit.cloudera.org:8080/#/c/12892/1/docker/monitor.py@88
PS1, Line 88: 
> flake8: E302 expected 2 blank lines, found 1
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 12:07:02 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has abandoned this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................


Abandoned

Superceded by https://gerrit.cloudera.org/c/23745/
-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 10
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12892/2/docker/monitor.py
File docker/monitor.py:

http://gerrit.cloudera.org:8080/#/c/12892/2/docker/monitor.py@75
PS2, Line 75:  
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/12892/2/docker/monitor.py@75
PS2, Line 75:   https://gitlab.com/procps-ng/procps/blob/master/proc/sysinfo.c#L795), 
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 12:05:34 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................


Patch Set 9: Code-Review+2

These seem like reasonable changes.


-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 9
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Feb 2023 21:29:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2604/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 12:49:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12892

to look at the new patch set (#10).

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................

Make Docker-based tests available on more hosting OS platforms

Tweak the test driver and the monitoring code to be compatible with
more OS versions:

1. Change the code collecting memory statistics to go directly to
   /proc/meminfo instead of parsing the output of 'free', which
   requires different arguments on different OS distributions.
   This makes test-with-docker.py depend on the MemAvailable field
   in /proc/meminfo, which should be present on kernels v3.14 and above.
   This also foregoes forking 'free' once per second.

2. Relax the check for a valid timezone specifier.
   On Ubuntu 14.04 /etc/localtime is a copy of a timezone file instead
   of being a symlink to a timezone file.
   Add an alternative check that accepts this option for timezone
   synchronization between the host and the Docker containers.

3. Centos 6 did not like the leading dash in the 'ps' command argument
   list. Change this to a universally accepted form by dropping
   the leading dash.
   Tested by running 'ps axho' manually on all OSs supported for
   Docker-based tests.

Change-Id: I6d326611772facc193d8e509a827515f10207808
---
M docker/entrypoint.sh
M docker/monitor.py
M docker/test-with-docker.py
3 files changed, 51 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/12892/10
-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 10
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12892

to look at the new patch set (#9).

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................

Make Docker-based tests available on more hosting OS platforms

Tweak the test driver and the monitoring code to be compatible with
more OS versions:

1. Change the code collecting memory statistics to go directly to
   /proc/meminfo instead of parsing the output of 'free', which
   requires different arguments on different OS distributions.
   This makes test-with-docker.py depend on the MemAvailable field
   in /proc/meminfo, which should be present on kernels v3.14 and above.
   This also foregoes forking 'free' once per second.

2. Relax the check for a valid timezone specifier.
   On Ubuntu 14.04 /etc/localtime is a copy of a timezone file instead
   of being a symlink to a timezone file.
   Add an alternative check that accepts this option for timezone
   synchronization between the host and the Docker containers.

3. Centos 6 did not like the leading dash in the 'ps' command argument
   list. Change this to a universally accepted form by dropping
   the leading dash.
   Tested by running 'ps axho' manually on all OSs supported for
   Docker-based tests.

Change-Id: I6d326611772facc193d8e509a827515f10207808
---
M docker/entrypoint.sh
M docker/monitor.py
M docker/test-with-docker.py
3 files changed, 51 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/12892/9
-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 9
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12276/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 9
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 31 Jan 2023 18:44:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12892

to look at the new patch set (#3).

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................

Make Docker-based tests available on more hosting OS platforms

Tweak the test driver and the monitoring code to be compatible with
more OS versions:

1. Change the code collecting memory statistics to go directly to
   /proc/meminfo instead of parsing the output of 'free', which
   requires different arguments on different OS distributions.
   This makes test-with-docker.py depend on the MemAvailable field
   in /proc/meminfo, which should be present on kernels v3.14 and above.
   This also foregoes forking 'free' once per second.

2. Relax the check for a valid timezone specifier.
   On Ubuntu 14.04 /etc/localtime is a copy of a timezone file instead
   of being a symlink to a timezone file.
   Add an alternative check that accepts this option for timezone
   synchronization between the host and the Docker containers.

3. Centos 6 did not like the leading dash in the 'ps' command argument
   list. Change this to a universally accepted form by dropping
   the leading dash.
   Tested by running 'ps axho' manually on all OSs supported for
   Docker-based tests.

Change-Id: I6d326611772facc193d8e509a827515f10207808
---
M docker/entrypoint.sh
M docker/monitor.py
M docker/test-with-docker.py
3 files changed, 51 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/12892/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] [Docker] Enable running docker-based tests on Ubuntu 14

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: [Docker] Enable running docker-based tests on Ubuntu 14
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12892/1/docker/monitor.py
File docker/monitor.py:

http://gerrit.cloudera.org:8080/#/c/12892/1/docker/monitor.py@75
PS1, Line 75: i
flake8: E501 line too long (93 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/12892/1/docker/monitor.py@81
PS1, Line 81:  
flake8: E201 whitespace after '('


http://gerrit.cloudera.org:8080/#/c/12892/1/docker/monitor.py@88
PS1, Line 88: def _mem_gb_from_meminfo(counters, key):
flake8: E302 expected 2 blank lines, found 1



-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Mar 2019 16:20:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12892

to look at the new patch set (#2).

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................

Make Docker-based tests available on more hosting OS platforms

Tweak the test driver and the monitoring code to be compatible with
more OS versions:

1. Change the code collecting memory statistics to go directly to
   /proc/meminfo instead of parsing the output of 'free', which
   requires different arguments on different OS distributions.
   This makes test-with-docker.py depend on the MemAvailable field
   in /proc/meminfo, which should be present on kernels v3.14 and above.
   This also foregoes forking 'free' once per second.

2. Relax the check for a valid timezone specifier.
   On Ubuntu 14.04 /etc/localtime is a copy of a timezone file instead
   of being a symlink to a timezone file.
   Add an alternative check that accepts this option for timezone
   synchronization between the host and the Docker containers.

3. Centos 6 did not like the leading dash in the 'ps' command argument
   list. Change this to a universally accepted form by dropping
   the leading dash.
   Tested by running 'ps axho' manually on all OSs supported for
   Docker-based tests.

Change-Id: I6d326611772facc193d8e509a827515f10207808
---
M docker/entrypoint.sh
M docker/monitor.py
M docker/test-with-docker.py
3 files changed, 51 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/12892/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2603/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 12:37:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................


Patch Set 5: Verified-1

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/11063/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 5
Gerrit-Owner: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Sun, 31 Jul 2022 21:16:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Make Docker-based tests available on more hosting OS platforms

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12892 )

Change subject: Make Docker-based tests available on more hosting OS platforms
......................................................................


Patch Set 10: Code-Review+2

Rebased from many months ago with a nominal conflict: the removed code section that parsed the output of 'free' was updated for Python3's Unicode logic in the meantime.

Carry +2 from Michael


-- 
To view, visit http://gerrit.cloudera.org:8080/12892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d326611772facc193d8e509a827515f10207808
Gerrit-Change-Number: 12892
Gerrit-PatchSet: 10
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 May 2025 14:02:33 +0000
Gerrit-HasComments: No