You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/03/21 22:13:17 UTC
[kudu-CR] verify jars.pl: ignore gradle-wrapper.jar
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9745
to review the following change.
Change subject: verify_jars.pl: ignore gradle-wrapper.jar
......................................................................
verify_jars.pl: ignore gradle-wrapper.jar
If you've run the gradle build, the downloaded wrapper is processed and its
classes are flagged as NON_KUDU errors.
I also ran the script on gradle-built artifacts, but they don't appear to be
shaded in the same way as maven-built ones; see KUDU-2365 for more details.
Change-Id: If76c67741658346b0a2b844a765482e8feab8b81
---
M build-support/verify_jars.pl
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/9745/1
--
To view, visit http://gerrit.cloudera.org:8080/9745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If76c67741658346b0a2b844a765482e8feab8b81
Gerrit-Change-Number: 9745
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] verify jars.pl: ignore gradle-wrapper.jar
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9745 )
Change subject: verify_jars.pl: ignore gradle-wrapper.jar
......................................................................
verify_jars.pl: ignore gradle-wrapper.jar
If you've run the gradle build, the downloaded wrapper is processed and its
classes are flagged as NON_KUDU errors.
I also ran the script on gradle-built artifacts, but they don't appear to be
shaded in the same way as maven-built ones; see KUDU-2365 for more details.
Change-Id: If76c67741658346b0a2b844a765482e8feab8b81
Reviewed-on: http://gerrit.cloudera.org:8080/9745
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M build-support/verify_jars.pl
1 file changed, 8 insertions(+), 2 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If76c67741658346b0a2b844a765482e8feab8b81
Gerrit-Change-Number: 9745
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] verify jars.pl: ignore gradle-wrapper.jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9745 )
Change subject: verify_jars.pl: ignore gradle-wrapper.jar
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If76c67741658346b0a2b844a765482e8feab8b81
Gerrit-Change-Number: 9745
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 21 Mar 2018 22:33:44 +0000
Gerrit-HasComments: No