Integrating destination patch into the code base

[Rajith Attapattu <ra...@gmail.com>]

Once we get agreement on the destination work, the next step is to
integrate it into the code base.
I see the following options. Please feel free to provide your feedback on
the options provide or even suggest new options.
I'm quite happy to work with any option the majority feels the best.

1. Integrate into both 0-8 and 0-10 code paths.

2. Integrate into 0-10 only.  - This would be tricky as there is a fair bit
of common code that uses destination stuff.

3. Have a new implementation of Session, Producer, Consumer etc for 0-10
that exclusively uses the new destination impl.
    We could then use AMQConnectionDelegate_0_10 as a point to plug in this
new structure when 0-10 is used.

   (Note: I'm not advocating a rewrite, rather to reuse as much code as
possible, and by moving necessary pieces from common code into the specific
implementation we could do #2 without being encumbered by common code).
   The flip side is code duplication.

Regards,

Rajith

Re: Integrating destination patch into the code base

[Rajith Attapattu <ra...@gmail.com>]

Thanks Guy for the feedback !
Lets focus on option #1.
Robbie I would need a bit of help with integrating into the 0-8 codepath :)

I also agree that the work should be on the branch until we are satisfied
with the integration.
The bulk of the work and the risk involved is primarily in this part.
The code so far is independent and not connected with anything, and hence
there is no real value of it being on trunk.

I still need to complete the unit tests for the work I posted.
Once done I will tackle the integration part.

Regards,

Rajith

On Fri, Apr 6, 2012 at 7:57 AM, Robbie Gemmell <ro...@gmail.com>wrote:

> I should have added, I think the work so far should continue to live
> on its branch because until integrating it with the rest of the client
> (which is the more interesting bit to the puzzle) really gets underway
> the approach is still really unproven and there is little benefit to
> it being on trunk before that happens.
>
> Robbie
>
> On 6 April 2012 12:31, Robbie Gemmell <ro...@gmail.com> wrote:
> > Option 1 seems like the only sensible course of action, options 2 and
> > 3 would just be continuing further down the paths that lead us where
> > we are now. At the end of this process there should really be less
> > arbitrary segregation of codepaths and less legacy cruft lying around,
> > not more of it.
> >
> > Robbie
> >
> > On 5 April 2012 16:34, Rajith Attapattu <ra...@gmail.com> wrote:
> >> Once we get agreement on the destination work, the next step is to
> >> integrate it into the code base.
> >> I see the following options. Please feel free to provide your feedback
> on
> >> the options provide or even suggest new options.
> >> I'm quite happy to work with any option the majority feels the best.
> >>
> >> 1. Integrate into both 0-8 and 0-10 code paths.
> >>
> >> 2. Integrate into 0-10 only.  - This would be tricky as there is a fair
> bit
> >> of common code that uses destination stuff.
> >>
> >> 3. Have a new implementation of Session, Producer, Consumer etc for 0-10
> >> that exclusively uses the new destination impl.
> >>    We could then use AMQConnectionDelegate_0_10 as a point to plug in
> this
> >> new structure when 0-10 is used.
> >>
> >>   (Note: I'm not advocating a rewrite, rather to reuse as much code as
> >> possible, and by moving necessary pieces from common code into the
> specific
> >> implementation we could do #2 without being encumbered by common code).
> >>   The flip side is code duplication.
> >>
> >> Regards,
> >>
> >> Rajith
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> For additional commands, e-mail: dev-help@qpid.apache.org
>
>

Re: Integrating destination patch into the code base

[Robbie Gemmell <ro...@gmail.com>]

I should have added, I think the work so far should continue to live
on its branch because until integrating it with the rest of the client
(which is the more interesting bit to the puzzle) really gets underway
the approach is still really unproven and there is little benefit to
it being on trunk before that happens.

Robbie

On 6 April 2012 12:31, Robbie Gemmell <ro...@gmail.com> wrote:
> Option 1 seems like the only sensible course of action, options 2 and
> 3 would just be continuing further down the paths that lead us where
> we are now. At the end of this process there should really be less
> arbitrary segregation of codepaths and less legacy cruft lying around,
> not more of it.
>
> Robbie
>
> On 5 April 2012 16:34, Rajith Attapattu <ra...@gmail.com> wrote:
>> Once we get agreement on the destination work, the next step is to
>> integrate it into the code base.
>> I see the following options. Please feel free to provide your feedback on
>> the options provide or even suggest new options.
>> I'm quite happy to work with any option the majority feels the best.
>>
>> 1. Integrate into both 0-8 and 0-10 code paths.
>>
>> 2. Integrate into 0-10 only.  - This would be tricky as there is a fair bit
>> of common code that uses destination stuff.
>>
>> 3. Have a new implementation of Session, Producer, Consumer etc for 0-10
>> that exclusively uses the new destination impl.
>>    We could then use AMQConnectionDelegate_0_10 as a point to plug in this
>> new structure when 0-10 is used.
>>
>>   (Note: I'm not advocating a rewrite, rather to reuse as much code as
>> possible, and by moving necessary pieces from common code into the specific
>> implementation we could do #2 without being encumbered by common code).
>>   The flip side is code duplication.
>>
>> Regards,
>>
>> Rajith

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

Re: Integrating destination patch into the code base

[Rob Godfrey <ro...@gmail.com>]

On 6 April 2012 13:31, Robbie Gemmell <ro...@gmail.com> wrote:

> Option 1 seems like the only sensible course of action, options 2 and
> 3 would just be continuing further down the paths that lead us where
> we are now. At the end of this process there should really be less
> arbitrary segregation of codepaths and less legacy cruft lying around,
> not more of it.
>
Robbie
>



+1 ... Option 1) is really the only option

-- Rob


>
> On 5 April 2012 16:34, Rajith Attapattu <ra...@gmail.com> wrote:
> > Once we get agreement on the destination work, the next step is to
> > integrate it into the code base.
> > I see the following options. Please feel free to provide your feedback on
> > the options provide or even suggest new options.
> > I'm quite happy to work with any option the majority feels the best.
> >
> > 1. Integrate into both 0-8 and 0-10 code paths.
> >
> > 2. Integrate into 0-10 only.  - This would be tricky as there is a fair
> bit
> > of common code that uses destination stuff.
> >
> > 3. Have a new implementation of Session, Producer, Consumer etc for 0-10
> > that exclusively uses the new destination impl.
> >    We could then use AMQConnectionDelegate_0_10 as a point to plug in
> this
> > new structure when 0-10 is used.
> >
> >   (Note: I'm not advocating a rewrite, rather to reuse as much code as
> > possible, and by moving necessary pieces from common code into the
> specific
> > implementation we could do #2 without being encumbered by common code).
> >   The flip side is code duplication.
> >
> > Regards,
> >
> > Rajith
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
> For additional commands, e-mail: dev-help@qpid.apache.org
>
>

Re: Integrating destination patch into the code base

[Robbie Gemmell <ro...@gmail.com>]

Option 1 seems like the only sensible course of action, options 2 and
3 would just be continuing further down the paths that lead us where
we are now. At the end of this process there should really be less
arbitrary segregation of codepaths and less legacy cruft lying around,
not more of it.

Robbie

On 5 April 2012 16:34, Rajith Attapattu <ra...@gmail.com> wrote:
> Once we get agreement on the destination work, the next step is to
> integrate it into the code base.
> I see the following options. Please feel free to provide your feedback on
> the options provide or even suggest new options.
> I'm quite happy to work with any option the majority feels the best.
>
> 1. Integrate into both 0-8 and 0-10 code paths.
>
> 2. Integrate into 0-10 only.  - This would be tricky as there is a fair bit
> of common code that uses destination stuff.
>
> 3. Have a new implementation of Session, Producer, Consumer etc for 0-10
> that exclusively uses the new destination impl.
>    We could then use AMQConnectionDelegate_0_10 as a point to plug in this
> new structure when 0-10 is used.
>
>   (Note: I'm not advocating a rewrite, rather to reuse as much code as
> possible, and by moving necessary pieces from common code into the specific
> implementation we could do #2 without being encumbered by common code).
>   The flip side is code duplication.
>
> Regards,
>
> Rajith

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org