You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "msokolov (via GitHub)" <gi...@apache.org> on 2024/08/14 15:42:07 UTC
[PR] gh-13653: Call finish() from HnswGraphBuilder.build() [lucene]
msokolov opened a new pull request, #13655:
URL: https://github.com/apache/lucene/pull/13655
This utility method is no longer used by the indexing chain, only by some unit tests, so we missed tracking the change in behavior when merging. Maybe we ought to change the unit test instead? But it makes sense to me that build() should be consistent with what we do when flushing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] gh-13653: Call finish() from HnswGraphBuilder.build() [lucene]
Posted by "msokolov (via GitHub)" <gi...@apache.org>.
msokolov commented on PR #13655:
URL: https://github.com/apache/lucene/pull/13655#issuecomment-2289624603
> I think this is sane. Though it is used by incremental merger still, which is still a viable and good way to merge graphs :)
Oh! well, I have no excuse then :) Thanks for looking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] gh-13653: Call finish() from HnswGraphBuilder.build() [lucene]
Posted by "msokolov (via GitHub)" <gi...@apache.org>.
msokolov merged PR #13655:
URL: https://github.com/apache/lucene/pull/13655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org