You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/03/09 22:09:24 UTC

svn commit: r1734313 - in /jmeter/trunk: bin/templates/recording-with-think-time.jmx bin/templates/recording.jmx src/core/org/apache/jmeter/threads/gui/AbstractThreadGroupGui.java xdocs/changes.xml

Author: pmouawad
Date: Wed Mar  9 21:09:24 2016
New Revision: 1734313

URL: http://svn.apache.org/viewvc?rev=1734313&view=rev
Log:
Bug 59152 - Thread Group: Change "Action to be taken after a Sample Error" value from "Continue" to "Start Next thread loop"
#resolve #161
https://github.com/apache/jmeter/pull/161
Bugzilla Id: 59152

Modified:
    jmeter/trunk/bin/templates/recording-with-think-time.jmx
    jmeter/trunk/bin/templates/recording.jmx
    jmeter/trunk/src/core/org/apache/jmeter/threads/gui/AbstractThreadGroupGui.java
    jmeter/trunk/xdocs/changes.xml

Modified: jmeter/trunk/bin/templates/recording-with-think-time.jmx
URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/templates/recording-with-think-time.jmx?rev=1734313&r1=1734312&r2=1734313&view=diff
==============================================================================
--- jmeter/trunk/bin/templates/recording-with-think-time.jmx (original)
+++ jmeter/trunk/bin/templates/recording-with-think-time.jmx Wed Mar  9 21:09:24 2016
@@ -35,7 +35,7 @@
       </CookieManager>
       <hashTree/>
       <ThreadGroup guiclass="ThreadGroupGui" testclass="ThreadGroup" testname="Thread Group" enabled="true">
-        <stringProp name="ThreadGroup.on_sample_error">continue</stringProp>
+        <stringProp name="ThreadGroup.on_sample_error">startnextloop</stringProp>
         <elementProp name="ThreadGroup.main_controller" elementType="LoopController" guiclass="LoopControlPanel" testclass="LoopController" testname="Loop Controller" enabled="true">
           <boolProp name="LoopController.continue_forever">false</boolProp>
           <stringProp name="LoopController.loops">1</stringProp>

Modified: jmeter/trunk/bin/templates/recording.jmx
URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/templates/recording.jmx?rev=1734313&r1=1734312&r2=1734313&view=diff
==============================================================================
--- jmeter/trunk/bin/templates/recording.jmx (original)
+++ jmeter/trunk/bin/templates/recording.jmx Wed Mar  9 21:09:24 2016
@@ -35,7 +35,7 @@
       </CookieManager>
       <hashTree/>
       <ThreadGroup guiclass="ThreadGroupGui" testclass="ThreadGroup" testname="Thread Group" enabled="true">
-        <stringProp name="ThreadGroup.on_sample_error">continue</stringProp>
+        <stringProp name="ThreadGroup.on_sample_error">startnextloop</stringProp>
         <elementProp name="ThreadGroup.main_controller" elementType="LoopController" guiclass="LoopControlPanel" testclass="LoopController" testname="Loop Controller" enabled="true">
           <boolProp name="LoopController.continue_forever">false</boolProp>
           <stringProp name="LoopController.loops">1</stringProp>

Modified: jmeter/trunk/src/core/org/apache/jmeter/threads/gui/AbstractThreadGroupGui.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/threads/gui/AbstractThreadGroupGui.java?rev=1734313&r1=1734312&r2=1734313&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/threads/gui/AbstractThreadGroupGui.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/threads/gui/AbstractThreadGroupGui.java Wed Mar  9 21:09:24 2016
@@ -105,7 +105,7 @@ public abstract class AbstractThreadGrou
     }
     
     private void initGui() {
-        continueBox.setSelected(true);
+        startNextLoop.setSelected(true);
     }
 
     private JPanel createOnErrorPanel() {

Modified: jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1734313&r1=1734312&r2=1734313&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Wed Mar  9 21:09:24 2016
@@ -115,6 +115,7 @@ Summary
     </ul>
     </li>
     <li><code>httpsampler.await_termination_timeout</code> has been replaced by <code>httpsampler.parallel_download_thread_keepalive_inseconds</code> which is now the keep alive time for the parallel download threads (in seconds).</li>
+    <li>For Thread Group Test Element, the property "Action to be taken after a Sample Error" value has been switched from "Continue" to "Start Next thread loop". See <bugzilla>59152</bugzilla></li>
 </ul>
 
 <!-- =================== Improvements =================== -->
@@ -258,6 +259,7 @@ Summary
 <li><bug>59095</bug>Remove UserParameterXMLParser that was deprecated 8 years ago. Contributed by Benoit Wiart (benoit dot wiart at gmail.com)</li>
 <li><bug>58426</bug>Use DPI scaling of interface for high resolution devices (HiDPI support for Windows/Linux) - <i>BETA</i> see hidpi properties in bin/jmeter.properties</li>
 <li><bug>59105</bug>TableEditor : Add ability to paste rows from clipboard and delete multiple selection. Contributed by Vincent Herilier (vherilier at gmail.com)</li>
+<li><bug>59152</bug>Thread Group: Change "Action to be taken after a Sample Error" value from "Continue" to "Start Next thread loop". Contributed by Antonio Gomes Rodrigues (ra0077 at gmail.com)</li>
 </ul>
 <ch_section>Non-functional changes</ch_section>
 <ul>