[jira] [Commented] (FLINK-5132) Introduce the ResourceSpec for grouping different resource factors in API

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859567#comment-15859567 ] 

ASF GitHub Bot commented on FLINK-5132:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3114
  
    Looks good, merging this.
    As a followup, I am wondering if it makes sense to check already in the constructors whether values are valid (for example that the amount of memory it not negative).


> Introduce the ResourceSpec for grouping different resource factors in API
> -------------------------------------------------------------------------
>
>                 Key: FLINK-5132
>                 URL: https://issues.apache.org/jira/browse/FLINK-5132
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Zhijiang Wang
>            Assignee: Zhijiang Wang
>
> This is part of the fine-grained resource configuration.
> The current resource factors include cpu cores, heap memory, direct memory, native memory and state size.
> The *ResourceSpec* will provide some basic constructions for grouping different resource factors as needed and the construction can also be expanded easily for further requirements.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)