You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacopo Cappellato <ja...@hotwaxsystems.com> on 2017/12/11 08:55:21 UTC
Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/
base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java
On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> [...]
> Also for OFBIZ-9872 the Jira lacks a description to possibly understand
> why theses changes (notably why you rightly removed the "if
> (Debug.verboseOn())" test because it's done at the bottom level with "if
> (isOn(level)) {"
>
There is actually a valid reason for maintaining the pattern:
if (Debug.verboseOn()) {
Debug.logVerbose(string + concatenation + here);
}
In fact string concatenation (in any of its forms) adds some overhead
(computational, memory, garbage collection); since the string concatenation
is done before calling Debug.logVerbose (or similar methods), but it is
only useful if that log level is on (otherwise the call to logVerbose will
not produce any output) then it is wise to perform the verboseOn() check
before: if the call returns a false then at runtime the sting concatenation
will not be executed at all.
Jacopo
Re: svn commit: r1817750 - in
/ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/
base/component: ComponentConfig.java ComponentLoaderConfig.java
ComponentResourceHandler.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
Yes better to keep it indeed
Jacques
Le 11/12/2017 à 10:05, Taher Alkhateeb a écrit :
> Unless maybe something changed with the log4j API that I am unaware of. But
> I suspect that's hard to implement
>
> On Dec 11, 2017 12:01 PM, "Taher Alkhateeb" <sl...@gmail.com>
> wrote:
>
>> I agree with Jacopo. String concatenation is a relatively expensive
>> operation because strings are immutable and this is exactly why the log4j
>> library provides the checking methods. I would also note that you need
>> these checking functions the most when the call is most utilized (verbose
>> or debug).
>>
>> On Dec 11, 2017 11:55 AM, "Jacopo Cappellato" <jacopo.cappellato@
>> hotwaxsystems.com> wrote:
>>
>> On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux <
>> jacques.le.roux@les7arts.com> wrote:
>>
>>> [...]
>>> Also for OFBIZ-9872 the Jira lacks a description to possibly understand
>>> why theses changes (notably why you rightly removed the "if
>>> (Debug.verboseOn())" test because it's done at the bottom level with "if
>>> (isOn(level)) {"
>>>
>> There is actually a valid reason for maintaining the pattern:
>>
>> if (Debug.verboseOn()) {
>> Debug.logVerbose(string + concatenation + here);
>> }
>>
>> In fact string concatenation (in any of its forms) adds some overhead
>> (computational, memory, garbage collection); since the string concatenation
>> is done before calling Debug.logVerbose (or similar methods), but it is
>> only useful if that log level is on (otherwise the call to logVerbose will
>> not produce any output) then it is wise to perform the verboseOn() check
>> before: if the call returns a false then at runtime the sting concatenation
>> will not be executed at all.
>>
>> Jacopo
>>
>>
>>
Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/
base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java
Posted by Taher Alkhateeb <sl...@gmail.com>.
Unless maybe something changed with the log4j API that I am unaware of. But
I suspect that's hard to implement
On Dec 11, 2017 12:01 PM, "Taher Alkhateeb" <sl...@gmail.com>
wrote:
> I agree with Jacopo. String concatenation is a relatively expensive
> operation because strings are immutable and this is exactly why the log4j
> library provides the checking methods. I would also note that you need
> these checking functions the most when the call is most utilized (verbose
> or debug).
>
> On Dec 11, 2017 11:55 AM, "Jacopo Cappellato" <jacopo.cappellato@
> hotwaxsystems.com> wrote:
>
> On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
> > [...]
> > Also for OFBIZ-9872 the Jira lacks a description to possibly understand
> > why theses changes (notably why you rightly removed the "if
> > (Debug.verboseOn())" test because it's done at the bottom level with "if
> > (isOn(level)) {"
> >
>
> There is actually a valid reason for maintaining the pattern:
>
> if (Debug.verboseOn()) {
> Debug.logVerbose(string + concatenation + here);
> }
>
> In fact string concatenation (in any of its forms) adds some overhead
> (computational, memory, garbage collection); since the string concatenation
> is done before calling Debug.logVerbose (or similar methods), but it is
> only useful if that log level is on (otherwise the call to logVerbose will
> not produce any output) then it is wise to perform the verboseOn() check
> before: if the call returns a false then at runtime the sting concatenation
> will not be executed at all.
>
> Jacopo
>
>
>
Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/
base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java
Posted by Taher Alkhateeb <sl...@gmail.com>.
I agree with Jacopo. String concatenation is a relatively expensive
operation because strings are immutable and this is exactly why the log4j
library provides the checking methods. I would also note that you need
these checking functions the most when the call is most utilized (verbose
or debug).
On Dec 11, 2017 11:55 AM, "Jacopo Cappellato" <
jacopo.cappellato@hotwaxsystems.com> wrote:
On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> [...]
> Also for OFBIZ-9872 the Jira lacks a description to possibly understand
> why theses changes (notably why you rightly removed the "if
> (Debug.verboseOn())" test because it's done at the bottom level with "if
> (isOn(level)) {"
>
There is actually a valid reason for maintaining the pattern:
if (Debug.verboseOn()) {
Debug.logVerbose(string + concatenation + here);
}
In fact string concatenation (in any of its forms) adds some overhead
(computational, memory, garbage collection); since the string concatenation
is done before calling Debug.logVerbose (or similar methods), but it is
only useful if that log level is on (otherwise the call to logVerbose will
not produce any output) then it is wise to perform the verboseOn() check
before: if the call returns a false then at runtime the sting concatenation
will not be executed at all.
Jacopo
Re: svn commit: r1817750 - in
/ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/
base/component: ComponentConfig.java ComponentLoaderConfig.java
ComponentResourceHandler.java
Posted by Nicolas Malin <ni...@nereide.fr>.
Same feel from France center :)
Nicolas
Le 11/12/2017 à 11:50, Taher Alkhateeb a écrit :
> On a side note to Michael kudos on the massive bug hunting effort lately.
>
> On Dec 11, 2017 1:33 PM, "Michael Brohl" <mi...@ecomify.de> wrote:
>
>> I will see how I can handle this effectively without doing all my review
>> work twice.
>>
>> There should be not too much commits which are affected.
>>
>> I'll see if I can repair it this evening.
>>
>>
>> Am 11.12.17 um 11:29 schrieb Jacques Le Roux:
>>
>>> Michael,
>>>
>>> It would be easier for reviewers if you could revert your commits (not
>>> those of the weekend, I have not reviewed them all yet but most of them,
>>> and so far did not find any important issues, just few improvements I did).
>>> This would prevent us from double reviewing. For me at least r1817748 and
>>> 1817742 1817743 1817744 (the bigger ones ;))
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>> Le 11/12/2017 à 10:21, Michael Brohl a écrit :
>>>
>>>> These are good points, I wasn't aware of this and just saw the (in my
>>>> view) unnecessary extra lines of code.
>>>>
>>>> I will check my latest commits and change this back where it is
>>>> reasonable (i.e. where we have concatenations).
>>>>
>>>> Luckily, I just started this this morning and not during the heavier
>>>> commits over the weekend.
>>>>
>>>> This reminds me that it is NOT a good idea to do such changes along with
>>>> the commits of patches, it's too confusing.
>>>>
>>>> Thanks,
>>>>
>>>> Michael
>>>>
>>>>
>>>> Am 11.12.17 um 09:55 schrieb Jacopo Cappellato:
>>>>
>>>>> On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux <
>>>>> jacques.le.roux@les7arts.com> wrote:
>>>>>
>>>>> [...]
>>>>>> Also for OFBIZ-9872 the Jira lacks a description to possibly understand
>>>>>> why theses changes (notably why you rightly removed the "if
>>>>>> (Debug.verboseOn())" test because it's done at the bottom level with
>>>>>> "if
>>>>>> (isOn(level)) {"
>>>>>>
>>>>>> There is actually a valid reason for maintaining the pattern:
>>>>> if (Debug.verboseOn()) {
>>>>> Debug.logVerbose(string + concatenation + here);
>>>>> }
>>>>>
>>>>> In fact string concatenation (in any of its forms) adds some overhead
>>>>> (computational, memory, garbage collection); since the string
>>>>> concatenation
>>>>> is done before calling Debug.logVerbose (or similar methods), but it is
>>>>> only useful if that log level is on (otherwise the call to logVerbose
>>>>> will
>>>>> not produce any output) then it is wise to perform the verboseOn() check
>>>>> before: if the call returns a false then at runtime the sting
>>>>> concatenation
>>>>> will not be executed at all.
>>>>>
>>>>> Jacopo
>>>>>
>>>>>
>>>>
>>
Re: svn commit: r1817750 - in
/ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/
base/component: ComponentConfig.java ComponentLoaderConfig.java
ComponentResourceHandler.java
Posted by Michael Brohl <mi...@ecomify.de>.
I've reverted these commits and reapplied the original patches.
Thanks all for taking care,
Michael
Am 11.12.17 um 15:21 schrieb Jacques Le Roux:
> I reviewed r1817748 1817742 1817743 1817744 there are OK with me
>
> So you just have to revert the removing of the tests on Debug in these
> commits (IIRW only in r1817748 and r1817750)
>
> Notably beware of
>
> "if (debug) {" in r1817748.
>
> Jacques
>
>
> Le 11/12/2017 à 12:39, Michael Brohl a écrit :
>> Thanks, Taher! :-)
>>
>> Am 11.12.17 um 11:50 schrieb Taher Alkhateeb:
>>> On a side note to Michael kudos on the massive bug hunting effort
>>> lately.
>>>
>>> On Dec 11, 2017 1:33 PM, "Michael Brohl" <mi...@ecomify.de>
>>> wrote:
>>>
>>>> I will see how I can handle this effectively without doing all my
>>>> review
>>>> work twice.
>>>>
>>>> There should be not too much commits which are affected.
>>>>
>>>> I'll see if I can repair it this evening.
>>>>
>>>>
>>>> Am 11.12.17 um 11:29 schrieb Jacques Le Roux:
>>>>
>>>>> Michael,
>>>>>
>>>>> It would be easier for reviewers if you could revert your commits
>>>>> (not
>>>>> those of the weekend, I have not reviewed them all yet but most of
>>>>> them,
>>>>> and so far did not find any important issues, just few
>>>>> improvements I did).
>>>>> This would prevent us from double reviewing. For me at least
>>>>> r1817748 and
>>>>> 1817742 1817743 1817744 (the bigger ones ;))
>>>>>
>>>>> Thanks
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 11/12/2017 à 10:21, Michael Brohl a écrit :
>>>>>
>>>>>> These are good points, I wasn't aware of this and just saw the
>>>>>> (in my
>>>>>> view) unnecessary extra lines of code.
>>>>>>
>>>>>> I will check my latest commits and change this back where it is
>>>>>> reasonable (i.e. where we have concatenations).
>>>>>>
>>>>>> Luckily, I just started this this morning and not during the heavier
>>>>>> commits over the weekend.
>>>>>>
>>>>>> This reminds me that it is NOT a good idea to do such changes
>>>>>> along with
>>>>>> the commits of patches, it's too confusing.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Michael
>>>>>>
>>>>>>
>>>>>> Am 11.12.17 um 09:55 schrieb Jacopo Cappellato:
>>>>>>
>>>>>>> On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux <
>>>>>>> jacques.le.roux@les7arts.com> wrote:
>>>>>>>
>>>>>>> [...]
>>>>>>>> Also for OFBIZ-9872 the Jira lacks a description to possibly
>>>>>>>> understand
>>>>>>>> why theses changes (notably why you rightly removed the "if
>>>>>>>> (Debug.verboseOn())" test because it's done at the bottom level
>>>>>>>> with
>>>>>>>> "if
>>>>>>>> (isOn(level)) {"
>>>>>>>>
>>>>>>>> There is actually a valid reason for maintaining the pattern:
>>>>>>> if (Debug.verboseOn()) {
>>>>>>> Debug.logVerbose(string + concatenation + here);
>>>>>>> }
>>>>>>>
>>>>>>> In fact string concatenation (in any of its forms) adds some
>>>>>>> overhead
>>>>>>> (computational, memory, garbage collection); since the string
>>>>>>> concatenation
>>>>>>> is done before calling Debug.logVerbose (or similar methods),
>>>>>>> but it is
>>>>>>> only useful if that log level is on (otherwise the call to
>>>>>>> logVerbose
>>>>>>> will
>>>>>>> not produce any output) then it is wise to perform the
>>>>>>> verboseOn() check
>>>>>>> before: if the call returns a false then at runtime the sting
>>>>>>> concatenation
>>>>>>> will not be executed at all.
>>>>>>>
>>>>>>> Jacopo
>>>>>>>
>>>>>>>
>>>>>>
>>>>
>>
>>
>
Re: svn commit: r1817750 - in
/ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/
base/component: ComponentConfig.java ComponentLoaderConfig.java
ComponentResourceHandler.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
I reviewed r1817748 1817742 1817743 1817744 there are OK with me
So you just have to revert the removing of the tests on Debug in these commits (IIRW only in r1817748 and r1817750)
Notably beware of
"if (debug) {" in r1817748.
Jacques
Le 11/12/2017 à 12:39, Michael Brohl a écrit :
> Thanks, Taher! :-)
>
> Am 11.12.17 um 11:50 schrieb Taher Alkhateeb:
>> On a side note to Michael kudos on the massive bug hunting effort lately.
>>
>> On Dec 11, 2017 1:33 PM, "Michael Brohl" <mi...@ecomify.de> wrote:
>>
>>> I will see how I can handle this effectively without doing all my review
>>> work twice.
>>>
>>> There should be not too much commits which are affected.
>>>
>>> I'll see if I can repair it this evening.
>>>
>>>
>>> Am 11.12.17 um 11:29 schrieb Jacques Le Roux:
>>>
>>>> Michael,
>>>>
>>>> It would be easier for reviewers if you could revert your commits (not
>>>> those of the weekend, I have not reviewed them all yet but most of them,
>>>> and so far did not find any important issues, just few improvements I did).
>>>> This would prevent us from double reviewing. For me at least r1817748 and
>>>> 1817742 1817743 1817744 (the bigger ones ;))
>>>>
>>>> Thanks
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 11/12/2017 à 10:21, Michael Brohl a écrit :
>>>>
>>>>> These are good points, I wasn't aware of this and just saw the (in my
>>>>> view) unnecessary extra lines of code.
>>>>>
>>>>> I will check my latest commits and change this back where it is
>>>>> reasonable (i.e. where we have concatenations).
>>>>>
>>>>> Luckily, I just started this this morning and not during the heavier
>>>>> commits over the weekend.
>>>>>
>>>>> This reminds me that it is NOT a good idea to do such changes along with
>>>>> the commits of patches, it's too confusing.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Michael
>>>>>
>>>>>
>>>>> Am 11.12.17 um 09:55 schrieb Jacopo Cappellato:
>>>>>
>>>>>> On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux <
>>>>>> jacques.le.roux@les7arts.com> wrote:
>>>>>>
>>>>>> [...]
>>>>>>> Also for OFBIZ-9872 the Jira lacks a description to possibly understand
>>>>>>> why theses changes (notably why you rightly removed the "if
>>>>>>> (Debug.verboseOn())" test because it's done at the bottom level with
>>>>>>> "if
>>>>>>> (isOn(level)) {"
>>>>>>>
>>>>>>> There is actually a valid reason for maintaining the pattern:
>>>>>> if (Debug.verboseOn()) {
>>>>>> Debug.logVerbose(string + concatenation + here);
>>>>>> }
>>>>>>
>>>>>> In fact string concatenation (in any of its forms) adds some overhead
>>>>>> (computational, memory, garbage collection); since the string
>>>>>> concatenation
>>>>>> is done before calling Debug.logVerbose (or similar methods), but it is
>>>>>> only useful if that log level is on (otherwise the call to logVerbose
>>>>>> will
>>>>>> not produce any output) then it is wise to perform the verboseOn() check
>>>>>> before: if the call returns a false then at runtime the sting
>>>>>> concatenation
>>>>>> will not be executed at all.
>>>>>>
>>>>>> Jacopo
>>>>>>
>>>>>>
>>>>>
>>>
>
>
Re: svn commit: r1817750 - in
/ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/
base/component: ComponentConfig.java ComponentLoaderConfig.java
ComponentResourceHandler.java
Posted by Michael Brohl <mi...@ecomify.de>.
Thanks, Taher! :-)
Am 11.12.17 um 11:50 schrieb Taher Alkhateeb:
> On a side note to Michael kudos on the massive bug hunting effort lately.
>
> On Dec 11, 2017 1:33 PM, "Michael Brohl" <mi...@ecomify.de> wrote:
>
>> I will see how I can handle this effectively without doing all my review
>> work twice.
>>
>> There should be not too much commits which are affected.
>>
>> I'll see if I can repair it this evening.
>>
>>
>> Am 11.12.17 um 11:29 schrieb Jacques Le Roux:
>>
>>> Michael,
>>>
>>> It would be easier for reviewers if you could revert your commits (not
>>> those of the weekend, I have not reviewed them all yet but most of them,
>>> and so far did not find any important issues, just few improvements I did).
>>> This would prevent us from double reviewing. For me at least r1817748 and
>>> 1817742 1817743 1817744 (the bigger ones ;))
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>> Le 11/12/2017 à 10:21, Michael Brohl a écrit :
>>>
>>>> These are good points, I wasn't aware of this and just saw the (in my
>>>> view) unnecessary extra lines of code.
>>>>
>>>> I will check my latest commits and change this back where it is
>>>> reasonable (i.e. where we have concatenations).
>>>>
>>>> Luckily, I just started this this morning and not during the heavier
>>>> commits over the weekend.
>>>>
>>>> This reminds me that it is NOT a good idea to do such changes along with
>>>> the commits of patches, it's too confusing.
>>>>
>>>> Thanks,
>>>>
>>>> Michael
>>>>
>>>>
>>>> Am 11.12.17 um 09:55 schrieb Jacopo Cappellato:
>>>>
>>>>> On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux <
>>>>> jacques.le.roux@les7arts.com> wrote:
>>>>>
>>>>> [...]
>>>>>> Also for OFBIZ-9872 the Jira lacks a description to possibly understand
>>>>>> why theses changes (notably why you rightly removed the "if
>>>>>> (Debug.verboseOn())" test because it's done at the bottom level with
>>>>>> "if
>>>>>> (isOn(level)) {"
>>>>>>
>>>>>> There is actually a valid reason for maintaining the pattern:
>>>>> if (Debug.verboseOn()) {
>>>>> Debug.logVerbose(string + concatenation + here);
>>>>> }
>>>>>
>>>>> In fact string concatenation (in any of its forms) adds some overhead
>>>>> (computational, memory, garbage collection); since the string
>>>>> concatenation
>>>>> is done before calling Debug.logVerbose (or similar methods), but it is
>>>>> only useful if that log level is on (otherwise the call to logVerbose
>>>>> will
>>>>> not produce any output) then it is wise to perform the verboseOn() check
>>>>> before: if the call returns a false then at runtime the sting
>>>>> concatenation
>>>>> will not be executed at all.
>>>>>
>>>>> Jacopo
>>>>>
>>>>>
>>>>
>>
Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/
base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java
Posted by Taher Alkhateeb <sl...@gmail.com>.
On a side note to Michael kudos on the massive bug hunting effort lately.
On Dec 11, 2017 1:33 PM, "Michael Brohl" <mi...@ecomify.de> wrote:
> I will see how I can handle this effectively without doing all my review
> work twice.
>
> There should be not too much commits which are affected.
>
> I'll see if I can repair it this evening.
>
>
> Am 11.12.17 um 11:29 schrieb Jacques Le Roux:
>
>> Michael,
>>
>> It would be easier for reviewers if you could revert your commits (not
>> those of the weekend, I have not reviewed them all yet but most of them,
>> and so far did not find any important issues, just few improvements I did).
>> This would prevent us from double reviewing. For me at least r1817748 and
>> 1817742 1817743 1817744 (the bigger ones ;))
>>
>> Thanks
>>
>> Jacques
>>
>>
>> Le 11/12/2017 à 10:21, Michael Brohl a écrit :
>>
>>> These are good points, I wasn't aware of this and just saw the (in my
>>> view) unnecessary extra lines of code.
>>>
>>> I will check my latest commits and change this back where it is
>>> reasonable (i.e. where we have concatenations).
>>>
>>> Luckily, I just started this this morning and not during the heavier
>>> commits over the weekend.
>>>
>>> This reminds me that it is NOT a good idea to do such changes along with
>>> the commits of patches, it's too confusing.
>>>
>>> Thanks,
>>>
>>> Michael
>>>
>>>
>>> Am 11.12.17 um 09:55 schrieb Jacopo Cappellato:
>>>
>>>> On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux <
>>>> jacques.le.roux@les7arts.com> wrote:
>>>>
>>>> [...]
>>>>> Also for OFBIZ-9872 the Jira lacks a description to possibly understand
>>>>> why theses changes (notably why you rightly removed the "if
>>>>> (Debug.verboseOn())" test because it's done at the bottom level with
>>>>> "if
>>>>> (isOn(level)) {"
>>>>>
>>>>> There is actually a valid reason for maintaining the pattern:
>>>>
>>>> if (Debug.verboseOn()) {
>>>> Debug.logVerbose(string + concatenation + here);
>>>> }
>>>>
>>>> In fact string concatenation (in any of its forms) adds some overhead
>>>> (computational, memory, garbage collection); since the string
>>>> concatenation
>>>> is done before calling Debug.logVerbose (or similar methods), but it is
>>>> only useful if that log level is on (otherwise the call to logVerbose
>>>> will
>>>> not produce any output) then it is wise to perform the verboseOn() check
>>>> before: if the call returns a false then at runtime the sting
>>>> concatenation
>>>> will not be executed at all.
>>>>
>>>> Jacopo
>>>>
>>>>
>>>
>>>
>>
>
>
Re: svn commit: r1817750 - in
/ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/
base/component: ComponentConfig.java ComponentLoaderConfig.java
ComponentResourceHandler.java
Posted by Michael Brohl <mi...@ecomify.de>.
I will see how I can handle this effectively without doing all my review
work twice.
There should be not too much commits which are affected.
I'll see if I can repair it this evening.
Am 11.12.17 um 11:29 schrieb Jacques Le Roux:
> Michael,
>
> It would be easier for reviewers if you could revert your commits (not
> those of the weekend, I have not reviewed them all yet but most of
> them, and so far did not find any important issues, just few
> improvements I did).
> This would prevent us from double reviewing. For me at least r1817748
> and 1817742 1817743 1817744 (the bigger ones ;))
>
> Thanks
>
> Jacques
>
>
> Le 11/12/2017 à 10:21, Michael Brohl a écrit :
>> These are good points, I wasn't aware of this and just saw the (in my
>> view) unnecessary extra lines of code.
>>
>> I will check my latest commits and change this back where it is
>> reasonable (i.e. where we have concatenations).
>>
>> Luckily, I just started this this morning and not during the heavier
>> commits over the weekend.
>>
>> This reminds me that it is NOT a good idea to do such changes along
>> with the commits of patches, it's too confusing.
>>
>> Thanks,
>>
>> Michael
>>
>>
>> Am 11.12.17 um 09:55 schrieb Jacopo Cappellato:
>>> On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux <
>>> jacques.le.roux@les7arts.com> wrote:
>>>
>>>> [...]
>>>> Also for OFBIZ-9872 the Jira lacks a description to possibly
>>>> understand
>>>> why theses changes (notably why you rightly removed the "if
>>>> (Debug.verboseOn())" test because it's done at the bottom level
>>>> with "if
>>>> (isOn(level)) {"
>>>>
>>> There is actually a valid reason for maintaining the pattern:
>>>
>>> if (Debug.verboseOn()) {
>>> Debug.logVerbose(string + concatenation + here);
>>> }
>>>
>>> In fact string concatenation (in any of its forms) adds some overhead
>>> (computational, memory, garbage collection); since the string
>>> concatenation
>>> is done before calling Debug.logVerbose (or similar methods), but it is
>>> only useful if that log level is on (otherwise the call to
>>> logVerbose will
>>> not produce any output) then it is wise to perform the verboseOn()
>>> check
>>> before: if the call returns a false then at runtime the sting
>>> concatenation
>>> will not be executed at all.
>>>
>>> Jacopo
>>>
>>
>>
>
Re: svn commit: r1817750 - in
/ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/
base/component: ComponentConfig.java ComponentLoaderConfig.java
ComponentResourceHandler.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
Michael,
It would be easier for reviewers if you could revert your commits (not those of the weekend, I have not reviewed them all yet but most of them, and so
far did not find any important issues, just few improvements I did).
This would prevent us from double reviewing. For me at least r1817748 and 1817742 1817743 1817744 (the bigger ones ;))
Thanks
Jacques
Le 11/12/2017 à 10:21, Michael Brohl a écrit :
> These are good points, I wasn't aware of this and just saw the (in my view) unnecessary extra lines of code.
>
> I will check my latest commits and change this back where it is reasonable (i.e. where we have concatenations).
>
> Luckily, I just started this this morning and not during the heavier commits over the weekend.
>
> This reminds me that it is NOT a good idea to do such changes along with the commits of patches, it's too confusing.
>
> Thanks,
>
> Michael
>
>
> Am 11.12.17 um 09:55 schrieb Jacopo Cappellato:
>> On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux <
>> jacques.le.roux@les7arts.com> wrote:
>>
>>> [...]
>>> Also for OFBIZ-9872 the Jira lacks a description to possibly understand
>>> why theses changes (notably why you rightly removed the "if
>>> (Debug.verboseOn())" test because it's done at the bottom level with "if
>>> (isOn(level)) {"
>>>
>> There is actually a valid reason for maintaining the pattern:
>>
>> if (Debug.verboseOn()) {
>> Debug.logVerbose(string + concatenation + here);
>> }
>>
>> In fact string concatenation (in any of its forms) adds some overhead
>> (computational, memory, garbage collection); since the string concatenation
>> is done before calling Debug.logVerbose (or similar methods), but it is
>> only useful if that log level is on (otherwise the call to logVerbose will
>> not produce any output) then it is wise to perform the verboseOn() check
>> before: if the call returns a false then at runtime the sting concatenation
>> will not be executed at all.
>>
>> Jacopo
>>
>
>
Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/
base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java
Posted by Jacopo Cappellato <ja...@hotwaxsystems.com>.
Thank you Michael!
Please see a minor comment inline:
On Mon, Dec 11, 2017 at 10:21 AM, Michael Brohl <mi...@ecomify.de>
wrote:
>
> I will check my latest commits and change this back where it is reasonable
> (i.e. where we have concatenations).
>
Actually this is not only relevant for concatenations, but also when a
plain string constant is defined (i.e. "some string here").
Jacopo
Re: svn commit: r1817750 - in
/ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/
base/component: ComponentConfig.java ComponentLoaderConfig.java
ComponentResourceHandler.java
Posted by Michael Brohl <mi...@ecomify.de>.
These are good points, I wasn't aware of this and just saw the (in my
view) unnecessary extra lines of code.
I will check my latest commits and change this back where it is
reasonable (i.e. where we have concatenations).
Luckily, I just started this this morning and not during the heavier
commits over the weekend.
This reminds me that it is NOT a good idea to do such changes along with
the commits of patches, it's too confusing.
Thanks,
Michael
Am 11.12.17 um 09:55 schrieb Jacopo Cappellato:
> On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
>> [...]
>> Also for OFBIZ-9872 the Jira lacks a description to possibly understand
>> why theses changes (notably why you rightly removed the "if
>> (Debug.verboseOn())" test because it's done at the bottom level with "if
>> (isOn(level)) {"
>>
> There is actually a valid reason for maintaining the pattern:
>
> if (Debug.verboseOn()) {
> Debug.logVerbose(string + concatenation + here);
> }
>
> In fact string concatenation (in any of its forms) adds some overhead
> (computational, memory, garbage collection); since the string concatenation
> is done before calling Debug.logVerbose (or similar methods), but it is
> only useful if that log level is on (otherwise the call to logVerbose will
> not produce any output) then it is wise to perform the verboseOn() check
> before: if the call returns a false then at runtime the sting concatenation
> will not be executed at all.
>
> Jacopo
>