[GitHub] [pulsar] mattisonchao commented on a diff in pull request #15653: [fix][broker] Fix NPE when set `AutoTopicCreationOverride`

[GitBox <gi...@apache.org>]

mattisonchao commented on code in PR #15653:
URL: https://github.com/apache/pulsar/pull/15653#discussion_r875709900


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -834,9 +835,11 @@ protected void internalSetAutoTopicCreation(AsyncResponse asyncResponse,
                         "Invalid configuration for autoTopicCreationOverride. the detail is "
                                 + validateResult.getErrorInfo());
             }
-            if (maxPartitions > 0 && autoTopicCreationOverride.getDefaultNumPartitions() > maxPartitions) {
-                throw new RestException(Status.NOT_ACCEPTABLE,
-                        "Number of partitions should be less than or equal to " + maxPartitions);
+            if (Objects.equals(autoTopicCreationOverride.getTopicType(), TopicType.PARTITIONED.toString())) {
+                if (maxPartitions > 0 && autoTopicCreationOverride.getDefaultNumPartitions() > maxPartitions) {

Review Comment:
   A simple null check cannot clearly express why it is null here, which will increase the burden on the maintainers later.
   I think a better approach is to use logical judgments to avoid null checks everywhere.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org