You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2018/10/05 22:02:39 UTC
goodbye LogWriterI18n
I've just checked in a fairly large set of changes to remove all uses of
LogWriterI18n and to remove the LocalizedStrings.java class altogether.
The other I18n classes are still in place because they are in a public
package or are needed to make that stuff compile, but you should no
longer use them.
From now on please use the new log4j-based log service. If you must
use a LogWriter do not use the LogWriterI18n variant because you no
longer have a good framework for creating StringIDs to feed to its
methods. Just use regular Strings.
Re: goodbye LogWriterI18n
Posted by Udo Kohlmeyer <ud...@apache.org>.
Awesome work!!
I've previously attempted to remove the deprecated LogWriterI18n.. but
did ran out of time..
--Udo
On 10/8/18 11:20, Bruce Schuchardt wrote:
> Removal of LogWriterI18n is in JIRA:
> https://issues.apache.org/jira/browse/GEODE-258
>
> That's a subtask of GEODE-72
>
>
> On 10/5/18 3:38 PM, Jacob Barrett wrote:
>> Perhaps it would be wise to create a JIRA that lists things, like
>> this, we would like to remove from the public API come 2.0 so we
>> don’t forget.
>>
>>> On Oct 5, 2018, at 3:02 PM, Bruce Schuchardt
>>> <bs...@pivotal.io> wrote:
>>>
>>> I've just checked in a fairly large set of changes to remove all
>>> uses of LogWriterI18n and to remove the LocalizedStrings.java class
>>> altogether. The other I18n classes are still in place because they
>>> are in a public package or are needed to make that stuff compile,
>>> but you should no longer use them.
>>>
>>> From now on please use the new log4j-based log service. If you
>>> must use a LogWriter do not use the LogWriterI18n variant because
>>> you no longer have a good framework for creating StringIDs to feed
>>> to its methods. Just use regular Strings.
>>>
>>>
>
Re: goodbye LogWriterI18n
Posted by Bruce Schuchardt <bs...@pivotal.io>.
Removal of LogWriterI18n is in JIRA:
https://issues.apache.org/jira/browse/GEODE-258
That's a subtask of GEODE-72
On 10/5/18 3:38 PM, Jacob Barrett wrote:
> Perhaps it would be wise to create a JIRA that lists things, like this, we would like to remove from the public API come 2.0 so we don’t forget.
>
>> On Oct 5, 2018, at 3:02 PM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>>
>> I've just checked in a fairly large set of changes to remove all uses of LogWriterI18n and to remove the LocalizedStrings.java class altogether. The other I18n classes are still in place because they are in a public package or are needed to make that stuff compile, but you should no longer use them.
>>
>> From now on please use the new log4j-based log service. If you must use a LogWriter do not use the LogWriterI18n variant because you no longer have a good framework for creating StringIDs to feed to its methods. Just use regular Strings.
>>
>>
Re: goodbye LogWriterI18n
Posted by Galen O'Sullivan <go...@pivotal.io>.
This is excellent. Thanks for this improvement, Bruce.
On Fri, Oct 5, 2018 at 4:14 PM Jacob Barrett <jb...@pivotal.io> wrote:
> Maybe because you have too many Ps in your url. ;)
>
> > On Oct 5, 2018, at 3:56 PM, Bruce Schuchardt <bs...@pivotal.io>
> wrote:
> >
> > I think there's already one listing all of the deprecated APIs. This is
> one of them. issues.appache.org doesn't seem to be reachable from my
> machine this afternoon or I'd look up the ticket number.
> >
> >
> >> On 10/5/18 3:38 PM, Jacob Barrett wrote:
> >> Perhaps it would be wise to create a JIRA that lists things, like this,
> we would like to remove from the public API come 2.0 so we don’t forget.
> >>
> >>> On Oct 5, 2018, at 3:02 PM, Bruce Schuchardt <bs...@pivotal.io>
> wrote:
> >>>
> >>> I've just checked in a fairly large set of changes to remove all uses
> of LogWriterI18n and to remove the LocalizedStrings.java class altogether.
> The other I18n classes are still in place because they are in a public
> package or are needed to make that stuff compile, but you should no longer
> use them.
> >>>
> >>> From now on please use the new log4j-based log service. If you must
> use a LogWriter do not use the LogWriterI18n variant because you no longer
> have a good framework for creating StringIDs to feed to its methods. Just
> use regular Strings.
> >>>
> >>>
> >
>
Re: goodbye LogWriterI18n
Posted by Jacob Barrett <jb...@pivotal.io>.
Maybe because you have too many Ps in your url. ;)
> On Oct 5, 2018, at 3:56 PM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>
> I think there's already one listing all of the deprecated APIs. This is one of them. issues.appache.org doesn't seem to be reachable from my machine this afternoon or I'd look up the ticket number.
>
>
>> On 10/5/18 3:38 PM, Jacob Barrett wrote:
>> Perhaps it would be wise to create a JIRA that lists things, like this, we would like to remove from the public API come 2.0 so we don’t forget.
>>
>>> On Oct 5, 2018, at 3:02 PM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>>>
>>> I've just checked in a fairly large set of changes to remove all uses of LogWriterI18n and to remove the LocalizedStrings.java class altogether. The other I18n classes are still in place because they are in a public package or are needed to make that stuff compile, but you should no longer use them.
>>>
>>> From now on please use the new log4j-based log service. If you must use a LogWriter do not use the LogWriterI18n variant because you no longer have a good framework for creating StringIDs to feed to its methods. Just use regular Strings.
>>>
>>>
>
Re: goodbye LogWriterI18n
Posted by Bruce Schuchardt <bs...@pivotal.io>.
I think there's already one listing all of the deprecated APIs. This
is one of them. issues.appache.org doesn't seem to be reachable from my
machine this afternoon or I'd look up the ticket number.
On 10/5/18 3:38 PM, Jacob Barrett wrote:
> Perhaps it would be wise to create a JIRA that lists things, like this, we would like to remove from the public API come 2.0 so we don’t forget.
>
>> On Oct 5, 2018, at 3:02 PM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>>
>> I've just checked in a fairly large set of changes to remove all uses of LogWriterI18n and to remove the LocalizedStrings.java class altogether. The other I18n classes are still in place because they are in a public package or are needed to make that stuff compile, but you should no longer use them.
>>
>> From now on please use the new log4j-based log service. If you must use a LogWriter do not use the LogWriterI18n variant because you no longer have a good framework for creating StringIDs to feed to its methods. Just use regular Strings.
>>
>>
Re: goodbye LogWriterI18n
Posted by Jacob Barrett <jb...@pivotal.io>.
Perhaps it would be wise to create a JIRA that lists things, like this, we would like to remove from the public API come 2.0 so we don’t forget.
> On Oct 5, 2018, at 3:02 PM, Bruce Schuchardt <bs...@pivotal.io> wrote:
>
> I've just checked in a fairly large set of changes to remove all uses of LogWriterI18n and to remove the LocalizedStrings.java class altogether. The other I18n classes are still in place because they are in a public package or are needed to make that stuff compile, but you should no longer use them.
>
> From now on please use the new log4j-based log service. If you must use a LogWriter do not use the LogWriterI18n variant because you no longer have a good framework for creating StringIDs to feed to its methods. Just use regular Strings.
>
>