[GitHub] [incubator-superset] eschutho commented on a change in pull request #11289: feat: keep placeholder on multiselect

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #11289:
URL: https://github.com/apache/incubator-superset/pull/11289#discussion_r505847452



##########
File path: superset-frontend/src/explore/components/controls/MetricsControl.jsx
##########
@@ -337,7 +337,11 @@ export default class MetricsControl extends React.PureComponent {
         <OnPasteSelect
           isMulti={this.props.multi}
           name={`select-${this.props.name}`}
-          placeholder={t('choose a column or aggregate function')}
+          placeholder={
+            this.props.multi
+              ? t('choose one or more column or aggregate function')
+              : t('choose a column or aggregate function')

Review comment:
       @junlincc to confirm, you're going to revisit this text at a later date, correct? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org