You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "sparsick (via GitHub)" <gi...@apache.org> on 2025/10/22 11:37:02 UTC
[PR] chore: migrate junit 3/4 to junit 5 tests [maven-changes-plugin]
sparsick opened a new pull request, #611:
URL: https://github.com/apache/maven-changes-plugin/pull/611
AbstractMojoTestCase based tests will be migrate in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: migrate junit 3/4 to junit 5 tests [maven-changes-plugin]
Posted by "sparsick (via GitHub)" <gi...@apache.org>.
sparsick merged PR #611:
URL: https://github.com/apache/maven-changes-plugin/pull/611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: migrate junit 3/4 to junit 5 tests [maven-changes-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #611:
URL: https://github.com/apache/maven-changes-plugin/pull/611#discussion_r2462771775
##########
src/test/java/org/apache/maven/plugins/changes/jira/JiraUnicodeTestCase.java:
##########
@@ -47,6 +51,12 @@ public class JiraUnicodeTestCase extends AbstractMojoTestCase {
*/
private static final String TEST_TURTLES = "海龟一路下跌。";
+ @BeforeEach
+ public void setUp() throws Exception {
+ super.setUp();
+ }
+
+ @Test
Review Comment:
JUnit 3 base test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: migrate junit 3/4 to junit 5 tests [maven-changes-plugin]
Posted by "sparsick (via GitHub)" <gi...@apache.org>.
sparsick commented on code in PR #611:
URL: https://github.com/apache/maven-changes-plugin/pull/611#discussion_r2465085863
##########
src/test/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojoTest.java:
##########
@@ -23,13 +23,20 @@
import org.apache.maven.plugin.testing.AbstractMojoTestCase;
import org.codehaus.plexus.util.FileUtils;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
/**
* @author Olivier Lamy
* @version $Id$
*/
public class AnnouncementMojoTest extends AbstractMojoTestCase {
+ @BeforeEach
+ void setup() throws Exception {
+ super.setUp();
+ }
Review Comment:
On my local run it works. AbstractMojoTestCase based tests will be migrated in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: migrate junit 3/4 to junit 5 tests [maven-changes-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #611:
URL: https://github.com/apache/maven-changes-plugin/pull/611#discussion_r2462771476
##########
src/test/java/org/apache/maven/plugins/changes/announcement/AnnouncementMojoTest.java:
##########
@@ -23,13 +23,20 @@
import org.apache.maven.plugin.testing.AbstractMojoTestCase;
import org.codehaus.plexus.util.FileUtils;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
/**
* @author Olivier Lamy
* @version $Id$
*/
public class AnnouncementMojoTest extends AbstractMojoTestCase {
+ @BeforeEach
+ void setup() throws Exception {
+ super.setUp();
+ }
Review Comment:
`AbstractMojoTestCase` is JUnit 3 base .... does annotation will work here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: migrate junit 3/4 to junit 5 tests [maven-changes-plugin]
Posted by "sparsick (via GitHub)" <gi...@apache.org>.
sparsick commented on code in PR #611:
URL: https://github.com/apache/maven-changes-plugin/pull/611#discussion_r2465099043
##########
src/test/java/org/apache/maven/plugins/changes/jira/JiraUnicodeTestCase.java:
##########
@@ -47,6 +51,12 @@ public class JiraUnicodeTestCase extends AbstractMojoTestCase {
*/
private static final String TEST_TURTLES = "海龟一路下跌。";
+ @BeforeEach
+ public void setUp() throws Exception {
+ super.setUp();
+ }
+
+ @Test
Review Comment:
Yes, it is based on AbstractMojoTestCase that will be migrated in a separate PR. If it helps to be more transparent. I can leave the test in the original version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org