[GitHub] [airflow] dstandish commented on a diff in pull request #31266: GKEPodHook needs to have all methods KPO calls

["dstandish (via GitHub)" <gi...@apache.org>]

dstandish commented on code in PR #31266:
URL: https://github.com/apache/airflow/pull/31266#discussion_r1192795838


##########
airflow/providers/google/cloud/hooks/kubernetes_engine.py:
##########
@@ -373,10 +372,22 @@ def core_v1_client(self) -> client.CoreV1Api:
     def is_in_cluster(self) -> bool:
         return False
 
-    @staticmethod
-    def get_xcom_sidecar_container_image():
-        """Returns the xcom sidecar image that defined in the connection"""
-        return PodDefaults.SIDECAR_CONTAINER.image

Review Comment:
   we don't need this because returning None gets you to the same place. (and we shouldn't be using `pod_generator_deprecated` anyway)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org