You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2012/06/14 17:14:42 UTC

[jira] [Commented] (THRIFT-1622) Incorrect size returned on read

    [ https://issues.apache.org/jira/browse/THRIFT-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295092#comment-13295092 ] 

Hudson commented on THRIFT-1622:
--------------------------------

Integrated in Thrift #500 (See [https://builds.apache.org/job/Thrift/500/])
    THRIFT-1622. cpp: Incorrect size returned on read

This patch adds a missing 'xfer +=' in a few spots.

Patch: NN (Revision 1350268)

     Result = SUCCESS
bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1350268
Files : 
* /thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc

                
> Incorrect size returned on read
> -------------------------------
>
>                 Key: THRIFT-1622
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1622
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler
>    Affects Versions: 0.8, 0.9
>         Environment: Any
>            Reporter: NN
>            Assignee: NN
>              Labels: patch
>             Fix For: 0.9
>
>         Attachments: t_cpp_generator.cc.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The problem exists when reading list, set or map.
> The 'xfer' variable is not updated by size of beginning and ending.
> Current generated code:
> iprot->read***Begin();
> iprot->read***End();
> Correctly generated code:
> xfer += iprot->read***Begin();
> xfer += iprot->read***End();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira