You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@excalibur.apache.org by "Joerg Schaible (JIRA)" <de...@excalibur.apache.org> on 2005/08/15 17:43:53 UTC
[jira] Created: (EXLBR-28) CommonsLogger
CommonsLogger
-------------
Key: EXLBR-28
URL: http://issues.apache.org/jira/browse/EXLBR-28
Project: Excalibur Components
Type: New Feature
Components: Logger
Versions: 1.2
Reporter: Joerg Schaible
A Logger implementation that uses a Log object of commons logging.
My use case is a web application, that has to use commons-logging and utilizes FOP. FOP requires an Avalon logger instance. Therefore I created CommonsLogger to delegate to a logger of commons-logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
[jira] Commented: (EXLBR-28) CommonsLogger
Posted by "Carsten Ziegeler (JIRA)" <de...@excalibur.apache.org>.
[ http://issues.apache.org/jira/browse/EXLBR-28?page=comments#action_12318991 ]
Carsten Ziegeler commented on EXLBR-28:
---------------------------------------
Ok :) I just added the test as well. Can you please cross check and then close this bug?
Thanks again
Carsten
> CommonsLogger
> -------------
>
> Key: EXLBR-28
> URL: http://issues.apache.org/jira/browse/EXLBR-28
> Project: Excalibur Components
> Type: New Feature
> Components: Logger
> Versions: 1.2
> Reporter: Joerg Schaible
> Attachments: CommonsLogger.java, CommonsLoggerTest.java, simplelog.properties
>
> A Logger implementation that uses a Log object of commons logging.
> My use case is a web application, that has to use commons-logging and utilizes FOP. FOP requires an Avalon logger instance. Therefore I created CommonsLogger to delegate to a logger of commons-logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
[jira] Resolved: (EXLBR-28) CommonsLogger
Posted by "Carsten Ziegeler (JIRA)" <de...@excalibur.apache.org>.
[ http://issues.apache.org/jira/browse/EXLBR-28?page=all ]
Carsten Ziegeler resolved EXLBR-28:
-----------------------------------
Resolution: Fixed
I applied just the Logger class but not the test case as I think this class is trivial enough to be correct without a test case. This avoids the additional dependency. I hope this is ok for you?
> CommonsLogger
> -------------
>
> Key: EXLBR-28
> URL: http://issues.apache.org/jira/browse/EXLBR-28
> Project: Excalibur Components
> Type: New Feature
> Components: Logger
> Versions: 1.2
> Reporter: Joerg Schaible
> Attachments: CommonsLogger.java, CommonsLoggerTest.java, simplelog.properties
>
> A Logger implementation that uses a Log object of commons logging.
> My use case is a web application, that has to use commons-logging and utilizes FOP. FOP requires an Avalon logger instance. Therefore I created CommonsLogger to delegate to a logger of commons-logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
[jira] Closed: (EXLBR-28) CommonsLogger
Posted by "Joerg Schaible (JIRA)" <de...@excalibur.apache.org>.
[ http://issues.apache.org/jira/browse/EXLBR-28?page=all ]
Joerg Schaible closed EXLBR-28:
-------------------------------
Works now. Thanks for your help :)
> CommonsLogger
> -------------
>
> Key: EXLBR-28
> URL: http://issues.apache.org/jira/browse/EXLBR-28
> Project: Excalibur Components
> Type: New Feature
> Components: Logger
> Versions: 1.2
> Reporter: Joerg Schaible
> Attachments: CommonsLogger.java, CommonsLoggerTest.java, simplelog.properties
>
> A Logger implementation that uses a Log object of commons logging.
> My use case is a web application, that has to use commons-logging and utilizes FOP. FOP requires an Avalon logger instance. Therefore I created CommonsLogger to delegate to a logger of commons-logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
[jira] Commented: (EXLBR-28) CommonsLogger
Posted by "Joerg Schaible (JIRA)" <de...@excalibur.apache.org>.
[ http://issues.apache.org/jira/browse/EXLBR-28?page=comments#action_12318981 ]
Joerg Schaible commented on EXLBR-28:
-------------------------------------
As long as noone blames me for not existing unit tests ... ;-)
OTOH is the dependency really an issue? I always add test dependencies in the POM in an own section with a comment e.g.:
<dependencies>
<!--- runtime deps -->
<!--- compile time deps -->
<!--- test deps -->
< ... junit ... />
< ... commons-logging ... />
</dependencies>
With Maven2 we will have these different dependency scopes anyway.
> CommonsLogger
> -------------
>
> Key: EXLBR-28
> URL: http://issues.apache.org/jira/browse/EXLBR-28
> Project: Excalibur Components
> Type: New Feature
> Components: Logger
> Versions: 1.2
> Reporter: Joerg Schaible
> Attachments: CommonsLogger.java, CommonsLoggerTest.java, simplelog.properties
>
> A Logger implementation that uses a Log object of commons logging.
> My use case is a web application, that has to use commons-logging and utilizes FOP. FOP requires an Avalon logger instance. Therefore I created CommonsLogger to delegate to a logger of commons-logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
[jira] Commented: (EXLBR-28) CommonsLogger
Posted by "Joerg Schaible (JIRA)" <de...@excalibur.apache.org>.
[ http://issues.apache.org/jira/browse/EXLBR-28?page=comments#action_12319012 ]
Joerg Schaible commented on EXLBR-28:
-------------------------------------
Hi Carsten,
cross check NOT successful. The test is not grabbed by tge build. The project-commons.xml includes only "**/*TestCase*", so you will have to rename it by appending Case to the class. Additionally you've added the simple.properties as simple.ptoperties.txt. This one you will have to rename too.
- Jörg
> CommonsLogger
> -------------
>
> Key: EXLBR-28
> URL: http://issues.apache.org/jira/browse/EXLBR-28
> Project: Excalibur Components
> Type: New Feature
> Components: Logger
> Versions: 1.2
> Reporter: Joerg Schaible
> Attachments: CommonsLogger.java, CommonsLoggerTest.java, simplelog.properties
>
> A Logger implementation that uses a Log object of commons logging.
> My use case is a web application, that has to use commons-logging and utilizes FOP. FOP requires an Avalon logger instance. Therefore I created CommonsLogger to delegate to a logger of commons-logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
[jira] Commented: (EXLBR-28) CommonsLogger
Posted by "Joerg Schaible (JIRA)" <de...@excalibur.apache.org>.
[ http://issues.apache.org/jira/browse/EXLBR-28?page=comments#action_12318988 ]
Joerg Schaible commented on EXLBR-28:
-------------------------------------
Impl is committed fine.
Since the unit test just needs one additional dep I would appreciate, if it is included, too. Just add the properties file to impl/src/test and add to the POM:
<dependency>
<id>jmock</id>
<version>1.0.1</version>
<properties note="Only required by tests.">
<build>true</build>
</properties>
</dependency>
- Jörg
> CommonsLogger
> -------------
>
> Key: EXLBR-28
> URL: http://issues.apache.org/jira/browse/EXLBR-28
> Project: Excalibur Components
> Type: New Feature
> Components: Logger
> Versions: 1.2
> Reporter: Joerg Schaible
> Attachments: CommonsLogger.java, CommonsLoggerTest.java, simplelog.properties
>
> A Logger implementation that uses a Log object of commons logging.
> My use case is a web application, that has to use commons-logging and utilizes FOP. FOP requires an Avalon logger instance. Therefore I created CommonsLogger to delegate to a logger of commons-logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
[jira] Commented: (EXLBR-28) CommonsLogger
Posted by "Carsten Ziegeler (JIRA)" <de...@excalibur.apache.org>.
[ http://issues.apache.org/jira/browse/EXLBR-28?page=comments#action_12319021 ]
Carsten Ziegeler commented on EXLBR-28:
---------------------------------------
Gosh, you're right (of course). I was not really paying attention applying the test case, grmpf. Sorry about that. It should be fixed now.
> CommonsLogger
> -------------
>
> Key: EXLBR-28
> URL: http://issues.apache.org/jira/browse/EXLBR-28
> Project: Excalibur Components
> Type: New Feature
> Components: Logger
> Versions: 1.2
> Reporter: Joerg Schaible
> Attachments: CommonsLogger.java, CommonsLoggerTest.java, simplelog.properties
>
> A Logger implementation that uses a Log object of commons logging.
> My use case is a web application, that has to use commons-logging and utilizes FOP. FOP requires an Avalon logger instance. Therefore I created CommonsLogger to delegate to a logger of commons-logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
[jira] Updated: (EXLBR-28) CommonsLogger
Posted by "Joerg Schaible (JIRA)" <de...@excalibur.apache.org>.
[ http://issues.apache.org/jira/browse/EXLBR-28?page=all ]
Joerg Schaible updated EXLBR-28:
--------------------------------
Attachment: CommonsLogger.java
CommonsLoggerTest.java
simplelog.properties
Logger implementation with unit tests.
Unit tests itself need jmock as dependency and must be able to locate attached simplelog.properties as resource.
> CommonsLogger
> -------------
>
> Key: EXLBR-28
> URL: http://issues.apache.org/jira/browse/EXLBR-28
> Project: Excalibur Components
> Type: New Feature
> Components: Logger
> Versions: 1.2
> Reporter: Joerg Schaible
> Attachments: CommonsLogger.java, CommonsLoggerTest.java, simplelog.properties
>
> A Logger implementation that uses a Log object of commons logging.
> My use case is a web application, that has to use commons-logging and utilizes FOP. FOP requires an Avalon logger instance. Therefore I created CommonsLogger to delegate to a logger of commons-logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org
[jira] Commented: (EXLBR-28) CommonsLogger
Posted by "Carsten Ziegeler (JIRA)" <de...@excalibur.apache.org>.
[ http://issues.apache.org/jira/browse/EXLBR-28?page=comments#action_12318982 ]
Carsten Ziegeler commented on EXLBR-28:
---------------------------------------
No, such dependencies are not really an issue. I like to have as few as possible :)
Anyways, can you close this bug, if you think that your contribution has been applied properly, please?
If you think, I should apply the test case as well, I'll do.
Thanks for the contribution!
> CommonsLogger
> -------------
>
> Key: EXLBR-28
> URL: http://issues.apache.org/jira/browse/EXLBR-28
> Project: Excalibur Components
> Type: New Feature
> Components: Logger
> Versions: 1.2
> Reporter: Joerg Schaible
> Attachments: CommonsLogger.java, CommonsLoggerTest.java, simplelog.properties
>
> A Logger implementation that uses a Log object of commons logging.
> My use case is a web application, that has to use commons-logging and utilizes FOP. FOP requires an Avalon logger instance. Therefore I created CommonsLogger to delegate to a logger of commons-logging.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@excalibur.apache.org
For additional commands, e-mail: dev-help@excalibur.apache.org