You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/11 14:44:26 UTC
[GitHub] [incubator-doris] yangzhg commented on a change in pull request
#2883: add column type check when create bitmap index using create index
clause
yangzhg commented on a change in pull request #2883: add column type check when create bitmap index using create index clause
URL: https://github.com/apache/incubator-doris/pull/2883#discussion_r377677716
##########
File path: fe/src/main/java/org/apache/doris/analysis/CreateTableStmt.java
##########
@@ -412,9 +412,13 @@ public void analyze(Analyzer analyzer) throws UserException {
// key columns and none/replace aggregate non-key columns support
if (indexDef.getIndexType() == IndexDef.IndexType.BITMAP) {
- if (!(colType == PrimitiveType.TINYINT || colType == PrimitiveType.SMALLINT
- || colType == PrimitiveType.INT || colType == PrimitiveType.BIGINT ||
- colType == PrimitiveType.CHAR || colType == PrimitiveType.VARCHAR)) {
+ if (!(colType == PrimitiveType.TINYINT || colType == PrimitiveType.SMALLINT ||
Review comment:
it dose not support double and float and doubleļ¼ so cannot use isNumericType()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org